Bug fixes for targeting a world with resource borrows #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvinrp
changed the title
macovedj
approved these changes
May 22, 2024
src/generator.rs
Outdated
| TypeDefKind::Handle(Handle::Borrow(id)) => { | ||
| if in_world { | ||
| let type_info = &self.resolve.types[*id]; |
There was a problem hiding this comment.
nit: Could we pull the body of this case out into a method called is_export_resource (or something)? Keeps it a little more readable IMO.
fibonacci1729
approved these changes
May 22, 2024
mergify bot
pushed a commit
to andrzejressel/pulumi-wasm
that referenced
this pull request
Jun 30, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [cargo-component](https://github.com/bytecodealliance/cargo-component) | minor | `0.10.1` -> `0.13.0` | --- ### Release Notes <details> <summary>bytecodealliance/cargo-component (cargo-component)</summary> ### [`v0.13.2`](https://github.com/bytecodealliance/cargo-component/releases/tag/v0.13.2) [Compare Source](https://github.com/bytecodealliance/cargo-component/compare/v0.13.1...v0.13.2) #### What's Changed - Add `cargo component serve` subcommand by [@​primoly](https://github.com/primoly) in [bytecodealliance/cargo-component#305 - added wasmtime wasi args for `cargo component serve` by [@​calvinrp](https://github.com/calvinrp) in [bytecodealliance/cargo-component#308 #### New Contributors - [@​primoly](https://github.com/primoly) made their first contribution in [bytecodealliance/cargo-component#305 **Full Changelog**: bytecodealliance/cargo-component@v0.13.1...v0.13.2 ### [`v0.13.1`](https://github.com/bytecodealliance/cargo-component/releases/tag/v0.13.1) [Compare Source](https://github.com/bytecodealliance/cargo-component/compare/v0.13.0...v0.13.1) #### What's Changed - More `cargo component new` generator fixes by [@​calvinrp](https://github.com/calvinrp) in [bytecodealliance/cargo-component#304 **Full Changelog**: bytecodealliance/cargo-component@v0.13.0...v0.13.1 ### [`v0.13.0`](https://github.com/bytecodealliance/cargo-component/releases/tag/v0.13.0) [Compare Source](https://github.com/bytecodealliance/cargo-component/compare/v0.12.0...v0.13.0) #### What's Changed - set dev version by [@​calvinrp](https://github.com/calvinrp) in [bytecodealliance/cargo-component#297 - Bug fixes for targeting a world with resource borrows by [@​calvinrp](https://github.com/calvinrp) in [bytecodealliance/cargo-component#300 **Full Changelog**: bytecodealliance/cargo-component@v0.12.0...v0.13.0 ### [`v0.12.0`](https://github.com/bytecodealliance/cargo-component/releases/tag/v0.12.0) [Compare Source](https://github.com/bytecodealliance/cargo-component/compare/v0.11.0...v0.12.0) #### What's Changed - add support for missing settings from wit-bindgen by [@​sehnryr](https://github.com/sehnryr) in [bytecodealliance/cargo-component#273 - fix kebab case issue by [@​fibonacci1729](https://github.com/fibonacci1729) in [bytecodealliance/cargo-component#274 - Help mesasage improvement ([#​138](https://github.com/bytecodealliance/cargo-component/issues/138)) by [@​chikoski](https://github.com/chikoski) in [bytecodealliance/cargo-component#278 - Update the example to use the latest version of cargo-component by [@​rylev](https://github.com/rylev) in [bytecodealliance/cargo-component#283 - fix test assertions after rust upgrade by [@​calvinrp](https://github.com/calvinrp) in [bytecodealliance/cargo-component#287 - Add `profile.release` to `Cargo.toml` generated by `cargo component new` by [@​calvinrp](https://github.com/calvinrp) in [bytecodealliance/cargo-component#289 - Update install instruction to use --locked by [@​fibonacci1729](https://github.com/fibonacci1729) in [bytecodealliance/cargo-component#292 - Update to latest Warg release to support registry federation by [@​calvinrp](https://github.com/calvinrp) in [bytecodealliance/cargo-component#288 - removed unused warg-credentials dependency by [@​calvinrp](https://github.com/calvinrp) in [bytecodealliance/cargo-component#295 - Warg update 0.7 by [@​calvinrp](https://github.com/calvinrp) in [bytecodealliance/cargo-component#296 #### New Contributors - [@​sehnryr](https://github.com/sehnryr) made their first contribution in [bytecodealliance/cargo-component#273 - [@​fibonacci1729](https://github.com/fibonacci1729) made their first contribution in [bytecodealliance/cargo-component#274 - [@​chikoski](https://github.com/chikoski) made their first contribution in [bytecodealliance/cargo-component#278 - [@​calvinrp](https://github.com/calvinrp) made their first contribution in [bytecodealliance/cargo-component#287 **Full Changelog**: bytecodealliance/cargo-component@v0.11.0...v0.12.0 ### [`v0.11.0`](https://github.com/bytecodealliance/cargo-component/releases/tag/v0.11.0) [Compare Source](https://github.com/bytecodealliance/cargo-component/compare/v0.10.1...v0.11.0) #### Compatibility - Wasmtime: 17.0.0+ - WASI: 0.2.0 - Warg (registry support): 0.4.0 #### What's Changed - Update wit-bindgen and wasm-tools. by [@​sunfishcode](https://github.com/sunfishcode) in [bytecodealliance/cargo-component#266 - Synchronize artifact componentization. by [@​peterhuene](https://github.com/peterhuene) in [bytecodealliance/cargo-component#270 - Bump version to 0.11.0. by [@​peterhuene](https://github.com/peterhuene) in [bytecodealliance/cargo-component#271 **Full Changelog**: bytecodealliance/cargo-component@v0.10.1...v0.11.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/andrzejressel/pulumi-wasm).
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expanded test cases to cover issue #299
Also, when specifying an exact semver requirement, adds that exact requirement to the generated
Cargo.toml. There was mismatch before.wit-bindgen-rustgenerates different bindings forborrow<>of resources, depending on whether that type is exported in the world or not.&SomeTypevsSomeTypeBorrowin the generated bindings. Fixed the logic here to match that behavior. The revised test case should better cover future potential breakage.If interested, here is some of the logic on the
wit-bindgenside:https://github.com/bytecodealliance/wit-bindgen/blob/main/crates/rust/src/interface.rs#L2203-L2225