Download observing instead of intercepting #255
Conversation
ghost
assigned 
| || Download.class.isAssignableFrom(type) || type == byte[].class; | ||
| } | ||
|
|
||
| public void download(@Observes MethodExecuted event) { |
There was a problem hiding this comment.
this observer class is always called, on each request?
There was a problem hiding this comment.
method is called each request, but logic is only executed if isDownloadType
returns true, just like interceptors with accepts method (but a little faster now).
There was a problem hiding this comment.
Thanks a lot. I think that with observers we will only "intercept" if download are needed. But the logic is the same that interceptors. 🍡
There was a problem hiding this comment.
I did a simple test firing event only if download are needed, but in 10k requests it
increases like 20ms (nothing), so has not justified creation of an event just for it =)
|
|
||
| public void download(@Observes MethodExecuted event) { | ||
|
|
||
| if (isDownloadType(event.getControllerMethod().getMethod().getReturnType())) { |
There was a problem hiding this comment.
I'd use something like:
Download download = resolveDownload(result);
if (download != null) {
//....
}So isDownloadType is not needed.
Upload observing instead of intercepting
…pting Download observing instead of intercepting
#247 - Sending just for code review... do not merge yet! :)