-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support drawn features (gmf-drawfeature) in gmf-permalink #1059
Conversation
0890ab8
to
8133910
Compare
@fredj (or @fgravin) Ready for review. See also the live example. I think it would make sense if we renamed the following values (located in ngeo.js), i.e change: Thoughts ?
|
The permalink should be retro compatible. |
Looks good, waiting before merging |
Yes, it should be retro compatible... |
The |
You can try them here: https://geomapfish-demo.camptocamp.net/2.0 Examples (removed prefix: https://geomapfish-demo.camptocamp.net/2.0/theme/Transport?map_x=542000&map_y=154000&map_zoom=2&):
|
Thanks for your answers. @fgravin I shouldn't matter what names are used, i.e. @sbrunner I'll try each one of them, thanks. I'll make sure that these are backward compatible when read. For writing, the new format will be used. |
Ok |
8133910
to
b9a2488
Compare
:-) |
Ok so ready for a merge ? |
@fgravin You can merge. I'll rename the properties in an other PR. I'll also test the backward compatibility in an other PR as well. |
This PR introduces the support of drawn vector features by the
gmf-drawfeature
directive inside thegmf-permalink
service.Todo
Live example