Backward compatibility for rl_features

[adube]

This PR adds the backward compatibility for rl_features in the permalink, i.e. for the features of the redlining tool from 1.6.

Was blocked by

This PR was blocked by: #1069

To do

• Review

Test cases

You can try them here: https://geomapfish-demo.camptocamp.net/2.0

Examples (removed prefix: https://geomapfish-demo.camptocamp.net/2.0/theme/Transport?map_x=542000&map_y=154000&map_zoom=2&):

• point
  • http://adube.github.io/ngeo/ngeo-featurehash-write-new-properties/examples/contribs/gmf/drawfeature.html?rl_features=Fp%28w8saFhdf3!~name*Un%2520titre~fillColor*%2523ff0000%27strokeColor*%2523ff0000%27pointRadius*6%27fontColor*%2523000000%29
    _rl_features=Fp%28w8saFhdf3!~name_Un%2520titre~fillColor_%2523ff0000%27strokeColor_%2523ff0000%27pointRadius_6%27fontColor_%2523000000%29
  • works fine
  • fontColor is ignored
  • fillColor and strokeColor are the same, i.e. only one is used
• line
  • http://adube.github.io/ngeo/ngeo-featurehash-write-new-properties/examples/contribs/gmf/drawfeature.html?rl_features=Fl%28drh7F9tx2!htv_z1k_~~strokeColor*%2523ff0000%27strokeWidth*1%29
  • rl_features=Fl%28drh7F9tx2!htv_z1k_~~strokeColor*%2523ff0000%27strokeWidth*1%29
  • this string doesn't currently work locally, but works in the minimized version... that's rare. I don't know why yet.
• polygon
  • http://adube.github.io/ngeo/ngeo-featurehash-write-new-properties/examples/contribs/gmf/drawfeature.html?rl_features=Fa%285rx4F11p2!sp1!1rGh3h_gwr_rg9!grn-~showMeasure*true~fillColor*%2523ff0000%27strokeColor*%2523ff0000%27strokeWidth*1%29
  • rl_features=Fa%285rx4F11p2!sp1!1rGh3h_gwr_rg9!grn-~showMeasure*true~fillColor*%2523ff0000%27strokeColor*%2523ff0000%27strokeWidth*1%29
  • works fine
  • fillColor and strokeColor are the same, i.e. only one is used
• rectangle
  • http://adube.github.io/ngeo/ngeo-featurehash-write-new-properties/examples/contribs/gmf/drawfeature.html?rl_features=Fa%285n25Fhzc1!.hec!9bt*..gec!~isBox*true~fillColor*%2523ff0000%27strokeColor*%2523ff0000%27strokeWidth*1%29
  • rl_features=Fa%285n25Fhzc1!.hec!9bt*..gec!~isBox*true~fillColor*%2523ff0000%27strokeColor*%2523ff0000%27strokeWidth*1%29
  • works, but produces junk in the url object [Object]
  • fillColor and strokeColor are the same, i.e. only one is used
• circle
  • http://adube.github.io/ngeo/ngeo-featurehash-write-new-properties/examples/contribs/gmf/drawfeature.html?rl_features=Fa%287ya3Ff274!fjGqr-36G7f!qhF33AqnEhkByjD7yCy9C55EuuAk4Fh9*uvF7m_bdGyWnnGxWknG6m_bdGg9*uvFtuAk4Fx9C55ExjD7yCpnEhkBphF33A26G7f!ejGqr-ppG.ejGpr-26G6f!mhF23ArnEgkBxjD6yCx9C45EtuAj4Fg9*tvF6m_adGvWjnGwWmnG7m_adGh9*tvFuuAj4Fy9C45EyjD6yCsnEgkBnhF23A36G6f!fjGpr-~isCircle*true~fillColor*%2523ff0000%27strokeColor*%2523ff0000%27strokeWidth*1%29
  • rl_features=Fa%287ya3Ff274!fjGqr-36G7f!qhF33AqnEhkByjD7yCy9C55EuuAk4Fh9*uvF7m_bdGyWnnGxWknG6m_bdGg9*uvFtuAk4Fx9C55ExjD7yCpnEhkBphF33A26G7f!ejGqr-ppG.ejGpr-26G6f!mhF23ArnEgkBxjD6yCx9C45EtuAj4Fg9*tvF6m_adGvWjnGwWmnG7m_adGh9*tvFuuAj4Fy9C45EyjD6yCsnEgkBnhF23A36G6f!fjGpr-~isCircle*true~fillColor*%2523ff0000%27strokeColor*%2523ff0000%27strokeWidth*1%29
  • works fine
  • fillColor and strokeColor are the same, i.e. only one is used
• text
  • http://adube.github.io/ngeo/ngeo-featurehash-write-new-properties/examples/contribs/gmf/drawfeature.html?rl_features=Fp%285wx9F19ry_~name*Un%2520titre%27isLabel*true~fillColor*%2523ff0000%27strokeColor*%2523ff0000%27pointRadius*6%27fontColor*%2523000000%27fontSize*12px%27fontFamily*sans-serif%27graphic*false%29
  • rl_features=Fp%285wx9F19ry_~name*Un%2520titre%27isLabel*true~fillColor*%2523ff0000%27strokeColor*%2523ff0000%27pointRadius*6%27fontColor*%2523000000%27fontSize*12px%27fontFamily*sans-serif%27graphic*false%29
  • fontSize was 12px. Now it's in pt (converted)
  • fontFamily is ignored (not supported)
  • fillColor and strokeColor are ignored.
  • graphic, old ol2 value. Not used.

[adube]

@sbrunner I copied the examples you provided here #1059 (comment)

The line doesn't work. I noticed that there's two ~~ characters in the url. Is this a typo ? When I remove one of the two it works.

Please, let me know.

[sbrunner]

no its not a typo, an other example:
rl_features=Fl(drh7F9tx2!htv_z1k_~showMeasure*true~strokeColor*%2523ff0000%27strokeWidth*1)
it syntax is (for line): Fl(<geom>~<attributes>~<style>), it's possible that the current implementation don't support the style ...

[adube]

It does support the style. It's just that when two ~~ characters follow one an other an error is thrown.

@sbrunner Would you please open an issue about this ? It's out of scope of this PR.

[adube]

#1067 Should fix the issue with rectangles.

[adube]

@sbrunner The text type is the one we with issues we haven't discussed about yet. Here's a summary:

• fontSize -> we now use the size property, which is used by points to determine their radius AND by text to determine the font size in pt, not px. So, the value 12px we receive currently conflicts with what we have. What should we do about this ? I suggest simply reading it and convert it to the proper pt value using a conversion tool. @fredj Do you know any I could use ? Something like: http://websemantics.co.uk/resources/font_size_conversion_chart/
• fontFamily -> it is not supported to choose the font family in GMF v2, at least if wasn't included in the specs. This will be ignored. Do you agree ?
• graphic -> I don't know what that is.

[sbrunner]

+1 for fontsize
graphic just say to openlayer 2 that we don't have any icon, it should be ignored.
fontFamily can't be changed in the UI, he can be ignored.

[adube]

Excellent. I have what I need to continue.

@sbrunner Would you please link the issue about the linestring format in this PR ?

[sbrunner]

Witch issue? a new one?

[adube]

Yes, a new issue. See: #1062 (comment)

[sbrunner]

Ok, I miss your comment :-)

[adube]

Text now converts px -> pt. Live example updated. The only thing remaining that block this PR is: #1069 .

[fredj]

#1069 is now fixed

[adube]

Now that #1069 has been fixed, this is ready for review.

[fredj]

please squash all your commits into one

[fredj]

please squash all your commits into one

I've finally used the new squash and merge button

Thanks @adube

[adube]

I was used to squash all commits into one. Even with the new button, if you prefer people still squashing their commits themselves, please let me know. Thanks.