-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
breaking(integration_test_charm.yaml): Remove jhack tail
logs
#224
Conversation
Does it mean: impossible to speedup
|
Proposal: do we see the log file size? Can we skip jhack tail run for huge logs only (or limit it to last 10000 lines of the log, etc)? |
from Pietro
I don't think our team has resources to spend time optimizing it right now, so doesn't seem to be worth it
I don't think the complexity here is worth it fwiw, you can download the debug log and run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sad.
I take it the |
oops, thought I commented on #223 but looks like I forgot to hit "comment" button yes, the |
mm, too bad. Tomorrow I have some time to look at an optimization for --output mode |
is it expected that running jhack tail with |
Reverts #224 Uses huge speed improvement from canonical/jhack#175 you @PietroPasotti!
Reverts #224 Uses huge speed improvement from canonical/jhack#175 —thank you @PietroPasotti!
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [allure-pytest-collection-report](https://github.com/canonical/data-platform-workflows) | integration | major | `v18.0.0` -> `v20.0.1` | | [canonical/data-platform-workflows](https://github.com/canonical/data-platform-workflows) | action | major | `v18.0.0` -> `v20.0.1` | | [pytest-operator-cache](https://github.com/canonical/data-platform-workflows) | integration | major | `v18.0.0` -> `v20.0.1` | | [pytest-operator-groups](https://github.com/canonical/data-platform-workflows) | integration | major | `v18.0.0` -> `v20.0.1` | --- ### Release Notes <details> <summary>canonical/data-platform-workflows (allure-pytest-collection-report)</summary> ### [`v20.0.1`](https://github.com/canonical/data-platform-workflows/releases/tag/v20.0.1) [Compare Source](https://github.com/canonical/data-platform-workflows/compare/v20.0.0...v20.0.1) ##### What's Changed - patch(integration_test_charm.yaml): Capture tcpdump to debug GH artifacts issue by [@​carlcsaposs-canonical](https://github.com/carlcsaposs-canonical) in [canonical/data-platform-workflows#229 **Full Changelog**: canonical/data-platform-workflows@v20.0.0...v20.0.1 ### [`v20.0.0`](https://github.com/canonical/data-platform-workflows/releases/tag/v20.0.0) [Compare Source](https://github.com/canonical/data-platform-workflows/compare/v19.2.1...v20.0.0) ##### What's Changed - breaking: Remove sync_issue_to_jira.yaml by [@​carlcsaposs-canonical](https://github.com/carlcsaposs-canonical) in [canonical/data-platform-workflows#226 **Full Changelog**: canonical/data-platform-workflows@v19...v20.0.0 ### [`v19.2.1`](https://github.com/canonical/data-platform-workflows/releases/tag/v19.2.1) [Compare Source](https://github.com/canonical/data-platform-workflows/compare/v19.2.0...v19.2.1) ##### What's Changed - patch: Switch internal Jira issue sync from workflow to bot by [@​carlcsaposs-canonical](https://github.com/carlcsaposs-canonical) in [canonical/data-platform-workflows#227 **Full Changelog**: canonical/data-platform-workflows@v19.2.0...v19.2.1 ### [`v19.2.0`](https://github.com/canonical/data-platform-workflows/releases/tag/v19.2.0) [Compare Source](https://github.com/canonical/data-platform-workflows/compare/v19.1.0...v19.2.0) ##### What's Changed - compatible: Add sync_docs.yaml by [@​a-velasco](https://github.com/a-velasco) in [canonical/data-platform-workflows#220 **Full Changelog**: canonical/data-platform-workflows@v19.1.0...v19.2.0 ### [`v19.1.0`](https://github.com/canonical/data-platform-workflows/releases/tag/v19.1.0) [Compare Source](https://github.com/canonical/data-platform-workflows/compare/v19.0.0...v19.1.0) ##### What's Changed - compatible(integration_test_charm.yaml): Add `jhack tail` to logs by [@​carlcsaposs-canonical](https://github.com/carlcsaposs-canonical) in [canonical/data-platform-workflows#225 **Full Changelog**: canonical/data-platform-workflows@v19.0.0...v19.1.0 ### [`v19.0.0`](https://github.com/canonical/data-platform-workflows/releases/tag/v19.0.0) [Compare Source](https://github.com/canonical/data-platform-workflows/compare/v18.0.1...v19.0.0) #### What's Changed - breaking(integration_test_charm.yaml): Remove `jhack tail` logs by [@​carlcsaposs-canonical](https://github.com/carlcsaposs-canonical) in [canonical/data-platform-workflows#224 **Full Changelog**: canonical/data-platform-workflows@v18...v19.0.0 ### [`v18.0.1`](https://github.com/canonical/data-platform-workflows/releases/tag/v18.0.1) [Compare Source](https://github.com/canonical/data-platform-workflows/compare/v18.0.0...v18.0.1) #### What's Changed - patch(release_\*.yaml): Fix auto-generated release notes by [@​carlcsaposs-canonical](https://github.com/carlcsaposs-canonical) in [canonical/data-platform-workflows#222 **Full Changelog**: canonical/data-platform-workflows@v18.0.0...v18.0.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 1am and before 3am every weekday" in timezone Etc/UTC, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/canonical/mysql-router-k8s-operator). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yMC4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [canonical/data-platform-workflows](https://github.com/canonical/data-platform-workflows) | action | major | `v18.0.0` -> `v21.0.0` | | [pytest-github-secrets](https://github.com/canonical/data-platform-workflows) | integration | major | `v18.0.0` -> `v21.0.0` | | [pytest-operator-cache](https://github.com/canonical/data-platform-workflows) | integration | major | `v18.0.0` -> `v21.0.0` | | [pytest-operator-groups](https://github.com/canonical/data-platform-workflows) | integration | major | `v18.0.0` -> `v21.0.0` | --- ### Release Notes <details> <summary>canonical/data-platform-workflows (canonical/data-platform-workflows)</summary> ### [`v21.0.0`](https://github.com/canonical/data-platform-workflows/releases/tag/v21.0.0) [Compare Source](https://github.com/canonical/data-platform-workflows/compare/v20.0.3...v21.0.0) ##### What's Changed - breaking(integration_test_charm.yaml): Only run juju 3.6 tests on `schedule` by [@​carlcsaposs-canonical](https://github.com/carlcsaposs-canonical) in [canonical/data-platform-workflows#232 **Full Changelog**: canonical/data-platform-workflows@v20...v21.0.0 ### [`v20.0.3`](https://github.com/canonical/data-platform-workflows/releases/tag/v20.0.3) [Compare Source](https://github.com/canonical/data-platform-workflows/compare/v20.0.2...v20.0.3) ##### What's Changed - patch(integration_test_charm.yaml): Add missing timeout-minutes by [@​carlcsaposs-canonical](https://github.com/carlcsaposs-canonical) in [canonical/data-platform-workflows#231 **Full Changelog**: canonical/data-platform-workflows@v20.0.2...v20.0.3 ### [`v20.0.2`](https://github.com/canonical/data-platform-workflows/releases/tag/v20.0.2) [Compare Source](https://github.com/canonical/data-platform-workflows/compare/v20.0.1...v20.0.2) ##### What's Changed - patch(integration_test_charm.yaml): Fix tcpdump debug capture by [@​carlcsaposs-canonical](https://github.com/carlcsaposs-canonical) in [canonical/data-platform-workflows#230 **Full Changelog**: canonical/data-platform-workflows@v20.0.1...v20.0.2 ### [`v20.0.1`](https://github.com/canonical/data-platform-workflows/releases/tag/v20.0.1) [Compare Source](https://github.com/canonical/data-platform-workflows/compare/v20.0.0...v20.0.1) ##### What's Changed - patch(integration_test_charm.yaml): Capture tcpdump to debug GH artifacts issue by [@​carlcsaposs-canonical](https://github.com/carlcsaposs-canonical) in [canonical/data-platform-workflows#229 **Full Changelog**: canonical/data-platform-workflows@v20.0.0...v20.0.1 ### [`v20.0.0`](https://github.com/canonical/data-platform-workflows/releases/tag/v20.0.0) [Compare Source](https://github.com/canonical/data-platform-workflows/compare/v19.2.1...v20.0.0) #### What's Changed - breaking: Remove sync_issue_to_jira.yaml by [@​carlcsaposs-canonical](https://github.com/carlcsaposs-canonical) in [canonical/data-platform-workflows#226 **Full Changelog**: canonical/data-platform-workflows@v19...v20.0.0 ### [`v19.2.1`](https://github.com/canonical/data-platform-workflows/releases/tag/v19.2.1) [Compare Source](https://github.com/canonical/data-platform-workflows/compare/v19.2.0...v19.2.1) #### What's Changed - patch: Switch internal Jira issue sync from workflow to bot by [@​carlcsaposs-canonical](https://github.com/carlcsaposs-canonical) in [canonical/data-platform-workflows#227 **Full Changelog**: canonical/data-platform-workflows@v19.2.0...v19.2.1 ### [`v19.2.0`](https://github.com/canonical/data-platform-workflows/releases/tag/v19.2.0) [Compare Source](https://github.com/canonical/data-platform-workflows/compare/v19.1.0...v19.2.0) #### What's Changed - compatible: Add sync_docs.yaml by [@​a-velasco](https://github.com/a-velasco) in [canonical/data-platform-workflows#220 **Full Changelog**: canonical/data-platform-workflows@v19.1.0...v19.2.0 ### [`v19.1.0`](https://github.com/canonical/data-platform-workflows/releases/tag/v19.1.0) [Compare Source](https://github.com/canonical/data-platform-workflows/compare/v19.0.0...v19.1.0) ##### What's Changed - compatible(integration_test_charm.yaml): Add `jhack tail` to logs by [@​carlcsaposs-canonical](https://github.com/carlcsaposs-canonical) in [canonical/data-platform-workflows#225 **Full Changelog**: canonical/data-platform-workflows@v19.0.0...v19.1.0 ### [`v19.0.0`](https://github.com/canonical/data-platform-workflows/releases/tag/v19.0.0) [Compare Source](https://github.com/canonical/data-platform-workflows/compare/v18.0.1...v19.0.0) #### What's Changed - breaking(integration_test_charm.yaml): Remove `jhack tail` logs by [@​carlcsaposs-canonical](https://github.com/carlcsaposs-canonical) in [canonical/data-platform-workflows#224 **Full Changelog**: canonical/data-platform-workflows@v18...v19.0.0 ### [`v18.0.1`](https://github.com/canonical/data-platform-workflows/releases/tag/v18.0.1) [Compare Source](https://github.com/canonical/data-platform-workflows/compare/v18.0.0...v18.0.1) #### What's Changed - patch(release_\*.yaml): Fix auto-generated release notes by [@​carlcsaposs-canonical](https://github.com/carlcsaposs-canonical) in [canonical/data-platform-workflows#222 **Full Changelog**: canonical/data-platform-workflows@v18.0.0...v18.0.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 1am and before 3am every weekday" in timezone Etc/UTC, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/canonical/mysql-router-operator). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yMC4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Fixes #223