Screenshots wrong when display rotated

[DAVID9SE]

Hi!
I am using ubuntu frame for a kiosk. Everything went smoothly but now I am trying to implement screenshot-based sanity checks. When I call ubuntu-frame.screenshot the output image is shifted.

I am using a 1920x1080@60.0 screen that is rotated so orientation is set to left.
The program running is wpe-webkit-mir-kiosk.

Thanks a lot in advance

[Saviq]

Thanks @DAVID9SE, I can confirm this happening, thanks for letting us know, we'll get to work on a fix soon.

[Saviq]

Reproducer:

# cat display.config
layouts:
  default:
    cards:
    - card-id: 0
      unknown-1:
        orientation: left

$ WAYLAND_DISPLAY=wayland-1 ./build-Debug/bin/miral-shell --display-config=static=$PWD/display.config --add-wayland-extensions all &
$ WAYLAND_DISPLAY=wayland-1 grim

[Saviq]

Actually… this may be a problem with grim, as ubuntu-frame-vnc seems to be doing fine (except for rotated input, which is a separate issue).

[mattkae]

Maybe related: #3236

This may be one big issue with our clip area disrespecting transformations

[mattkae]

This looks quite suspect:

mir/src/server/frontend_wayland/output_manager.cpp

Line 98 in 5bb631f

// TODO: send correct output transform

[mattkae]

Update for posterity's sake: setting the correct transform actually hurts us a lot more than it should. However, using a buffer size that has the correctly transformed extents fixes us 😄