Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PPA FTBFS armhf/noble #3285

Closed
AlanGriffiths opened this issue Mar 14, 2024 · 1 comment · Fixed by #3290 or #3299
Closed

PPA FTBFS armhf/noble #3285

AlanGriffiths opened this issue Mar 14, 2024 · 1 comment · Fixed by #3290 or #3299
Assignees
Labels
triaged Triage into JIRA to plan it in

Comments

@AlanGriffiths
Copy link
Contributor

[ 53%] Building CXX object tests/mir_test_framework/CMakeFiles/mir-public-test-framework.dir/open_wrapper.cpp.o
cd /<<PKGBUILDDIR>>/build-armhf/tests/mir_test_framework && /usr/bin/c++ -DBOOST_ATOMIC_DYN_LINK -DBOOST_ATOMIC_NO_LIB -DBOOST_FILESYSTEM_DYN_LINK -DBOOST_FILESYSTEM_NO_LIB -DEGL_NO_X11 -DLTTNG_UST_HAVE_SDT_INTEGRATION -DMIR_BUILD_PLATFORM_GBM_KMS -DMIR_BUILD_PREFIX=\"/<<PKGBUILDDIR>>/build-armhf\" -DMIR_INSTALL_PREFIX=\"/usr\" -DMIR_SERVER_GRAPHICS_PLATFORM_ABI_STRING=\"22\" -DMIR_SERVER_INPUT_PLATFORM_ABI_STRING=\"9\" -DMIR_SERVER_PLATFORM_PATH=\"/usr/lib/arm-linux-gnueabihf/mir/server-platform\" -DMIR_VERSION_MAJOR=2 -DMIR_VERSION_MICRO=3 -DMIR_VERSION_MINOR=16 -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE -I/usr/src/googletest/googlemock/include -I/<<PKGBUILDDIR>>/include/miral -I/<<PKGBUILDDIR>>/src/include/server -I/usr/include/uuid -I/<<PKGBUILDDIR>>/include/test -I/<<PKGBUILDDIR>>/include/renderer -I/<<PKGBUILDDIR>>/include/renderers/gl -I/<<PKGBUILDDIR>>/tests/include -I/<<PKGBUILDDIR>> -I/<<PKGBUILDDIR>>/src/include/platform -I/<<PKGBUILDDIR>>/src/include/common -I/<<PKGBUILDDIR>>/src/include/client -I/<<PKGBUILDDIR>>/include/renderers/sw -I/<<PKGBUILDDIR>>/build-armhf/src/platform/graphics -I/<<PKGBUILDDIR>>/include/platform -I/<<PKGBUILDDIR>>/include/wayland -I/<<PKGBUILDDIR>>/src/include/wayland -I/<<PKGBUILDDIR>>/build-armhf/src/wayland -I/<<PKGBUILDDIR>>/include/core -I/<<PKGBUILDDIR>>/include/common -isystem /usr/include/libdrm -isystem /usr/include/umockdev-1.0 -isystem /usr/include/glib-2.0 -isystem /usr/lib/arm-linux-gnueabihf/glib-2.0/include -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fno-stack-clash-protection -Wformat -Werror=format-security -fdebug-prefix-map=/<<PKGBUILDDIR>>=/usr/src/mir-2.16.3+dev199-g24d5001542-0ubuntu24.04 -Wdate-time -D_FORTIFY_SOURCE=3 -pthread -g -Wall -fno-strict-aliasing  -Wnon-virtual-dtor -Wextra -fPIC -Werror -Wno-mismatched-tags -Wno-psabi -ffat-lto-objects -Wno-error=null-dereference -Wno-error=overloaded-virtual -Wno-sign-compare -Wno-error=maybe-uninitialized -fno-lto -Dregister= -std=c++23 -Wno-error=infinite-recursion -MD -MT tests/mir_test_framework/CMakeFiles/mir-public-test-framework.dir/open_wrapper.cpp.o -MF CMakeFiles/mir-public-test-framework.dir/open_wrapper.cpp.o.d -o CMakeFiles/mir-public-test-framework.dir/open_wrapper.cpp.o -c /<<PKGBUILDDIR>>/tests/mir_test_framework/open_wrapper.cpp
In file included from /usr/include/features.h:394,
                 from /usr/include/arm-linux-gnueabihf/c++/13/bits/os_defines.h:39,
                 from /usr/include/arm-linux-gnueabihf/c++/13/bits/c++config.h:679,
                 from /usr/include/c++/13/functional:48,
                 from /<<PKGBUILDDIR>>/tests/include/mir_test_framework/open_wrapper.h:19,
                 from /<<PKGBUILDDIR>>/tests/mir_test_framework/open_wrapper.cpp:24:
/usr/include/features-time64.h:26:5: error: #error "_TIME_BITS=64 is allowed only with _FILE_OFFSET_BITS=64"
   26 | #   error "_TIME_BITS=64 is allowed only with _FILE_OFFSET_BITS=64"
      |     ^~~~~
make[3]: *** [tests/mir_test_framework/CMakeFiles/mir-public-test-framework.dir/build.make:317: tests/mir_test_framework/CMakeFiles/mir-public-test-framework.dir/open_wrapper.cpp.o] Error 1

https://launchpadlibrarian.net/719328544/buildlog_ubuntu-noble-armhf.mir_2.16.3+dev199-g24d5001542-0ubuntu24.04_BUILDING.txt.gz

@Saviq Saviq changed the title PPA FTBFS armhf/nobel PPA FTBFS armhf/noble Mar 14, 2024
@RAOF
Copy link
Contributor

RAOF commented Mar 15, 2024

Oh, no. Our lifted-from-umockdev hack to make this work reliably on 32bit platforms has broken.

Hm, from that package (in noble-proposed, because this is still caught up in the 64-bit time_t apocalypse:

umockdev (0.18.0-1ubuntu2) noble; urgency=medium

  * Fix symbol redirections when using _FILE_OFFSET_BITS.

 -- Steve Langasek <steve.langasek@ubuntu.com>  Sun, 10 Mar 2024 00:05:34 +0000

umockdev (0.18.0-1ubuntu1) noble; urgency=medium

  * Add a patch to remove _FILE_OFFSET_BITS hack

 -- Zixing Liu <zixing.liu@canonical.com>  Sat, 09 Mar 2024 13:51:25 -0700

AlanGriffiths added a commit to Miriway/Miriway that referenced this issue Mar 15, 2024
AlanGriffiths added a commit to Miriway/Miriway that referenced this issue Mar 15, 2024
AlanGriffiths added a commit to Miriway/Miriway that referenced this issue Mar 15, 2024
@RAOF RAOF added the triaged Triage into JIRA to plan it in label Mar 18, 2024
@RAOF RAOF self-assigned this Mar 18, 2024
github-merge-queue bot pushed a commit that referenced this issue Mar 18, 2024
We're *mostly* insulated from this, but our tests need to intercept
calls to `open`, which means that we're exposed to some glibc internals
that change under `_TIME_BITS=64`.

Fortunately umockdev in the archive has already hit this, so adapt that
fix to our use.

Fixes: #3285
mattkae pushed a commit that referenced this issue Mar 28, 2024
We're *mostly* insulated from this, but our tests need to intercept
calls to `open`, which means that we're exposed to some glibc internals
that change under `_TIME_BITS=64`.

Fortunately umockdev in the archive has already hit this, so adapt that
fix to our use.

Fixes: #3285
mattkae pushed a commit that referenced this issue Mar 28, 2024
We're *mostly* insulated from this, but our tests need to intercept
calls to `open`, which means that we're exposed to some glibc internals
that change under `_TIME_BITS=64`.

Fortunately umockdev in the archive has already hit this, so adapt that
fix to our use.

Fixes: #3285
AlanGriffiths added a commit that referenced this issue Apr 3, 2024
We're *mostly* insulated from this, but our tests need to intercept
calls to `open`, which means that we're exposed to some glibc internals
that change under `_TIME_BITS=64`.

Fortunately umockdev in the archive has already hit this, so adapt that
fix to our use.

Fixes: #3285
github-merge-queue bot pushed a commit that referenced this issue Apr 8, 2024
## Release Notes
mir (2.16.4) UNRELEASED; urgency=medium

  * Bugfix release:
    - Ignoring zero length gamma curves for KMS outputs (Fixes: #3238)
    - Add hardware cursor support (Fixes: #3198)
- Screenshots now respect clipping areas and rotated outputs (Fixes:
#3236)
      (Fixes: #3259)
    - Fixed custom attributes propagation on outputs
      (Fixes: canonical/ubuntu-frame#172)
    - Handle the Ubuntu 64-bit time_t apocalypse (Fixes: #3285)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triaged Triage into JIRA to plan it in
Projects
None yet
2 participants