Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update modal component to support new theming variables #5106

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

bartaz
Copy link
Member

@bartaz bartaz commented Jun 3, 2024

Done

Updates modal component to support dark theme (via new color variables).

Related to: https://warthogs.atlassian.net/browse/WD-11799

Fixes: WD-11829

QA

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.

Screenshots

image

@webteam-app
Copy link

@bartaz bartaz added Feature 🎁 New feature or request Maintenance 🔨 Review: Design needed Review: QA needed Review: Code needed Review: Percy needed This PR needs a review of Percy for visual regressions and removed Feature 🎁 New feature or request labels Jun 3, 2024
@bartaz bartaz marked this pull request as ready for review June 3, 2024 16:45
@bartaz bartaz added Review: Percy +1 and removed Review: Percy needed This PR needs a review of Percy for visual regressions labels Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants