Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add modal & segmented control to color theme docs page #5118

Closed
wants to merge 1 commit into from

Conversation

jmuzina
Copy link
Member

@jmuzina jmuzina commented Jun 10, 2024

Done

In #5106 and #5111 , we added or altered theming support for the modal & segmented control components. However we did not update the color themes documentation to include these components in the list of themed components. This PR adds these components to that list.

QA

  • Open demo
  • Verify that the modal & segmented control have been added to the color theme-supported components list.

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.

Screenshots

Screenshot 2024-06-10 at 11 49 59 AM

@webteam-app
Copy link

@jmuzina jmuzina marked this pull request as ready for review June 10, 2024 16:27
@bartaz
Copy link
Member

bartaz commented Jun 10, 2024

Hey, thanks, but there is no need. This is the legacy documentation of the "old theming". It's mentioned as deprecated. There is no need to add any new components there (or at least we would have to add a lot more).

Not sure if there is anything else quick that we could do to make it less confusing (apart from removing this section completely or rewriting it with new theming docs).

EDIT:

Oh, I just noticed that it's not these docs that are marked deprecated, but section below it about setting default colour theme.

Well, the list of components is definitely not complete and it would be probably useless to keep it up to date (technically we soon want it to be ALL the components). So I think this should be rewritten properly to mention new theming via CSS variables, as per https://warthogs.atlassian.net/browse/WD-7593

@bartaz
Copy link
Member

bartaz commented Jun 17, 2024

I'm just closing this. Let's address it separately when we actually update the theming documentation properly.

@bartaz bartaz closed this Jun 17, 2024
@jmuzina jmuzina deleted the modal-segctl-theme-docn branch June 25, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants