Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update segmented control to use new color theme variables #5111

Merged

Conversation

jmuzina
Copy link
Member

@jmuzina jmuzina commented Jun 5, 2024

Done

Updates segmented control component so that the divider line between segmented control buttons uses new color theme variables.

This results in a change to the dark theme appearance of the segmented control, as previously it was always using the light theme appearance.

Fixes WD-11861

QA

  • Open segmented control example
  • Verify that the color of the separator bar between segmented control buttons is correct in each theme.

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.

Screenshots

Before
Screenshot 2024-06-05 at 12 05 42 PM
After
Screenshot 2024-06-05 at 12 06 00 PM

@jmuzina jmuzina added Review: Design needed Review: QA needed Maintenance 🔨 Review: Percy needed This PR needs a review of Percy for visual regressions labels Jun 5, 2024
@jmuzina jmuzina self-assigned this Jun 5, 2024
@webteam-app
Copy link

@jmuzina
Copy link
Member Author

jmuzina commented Jun 5, 2024

Percy does not currently capture a snapshot of the segmented control in dark theme so the Percy build shows no diffs.

Review segmented control in dark theme in demo and staging to see the difference introduced by this PR.

@jmuzina jmuzina marked this pull request as ready for review June 5, 2024 16:15
@jmuzina jmuzina requested a review from bartaz June 5, 2024 16:16
Copy link
Member

@bartaz bartaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@bartaz bartaz merged commit 994b85c into canonical:main Jun 5, 2024
6 checks passed
@jmuzina jmuzina deleted the segmented-control-color-theme-update branch June 5, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants