-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing bm deployment DO-659 #21
Conversation
@@ -1,6 +1,6 @@ | |||
--- | |||
- name: Install Xcode v{{ xcode_version }} # noqa: name[template] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[ansible-lint] reported by reviewdog 🐶
inline-env-var Command module does not accept setting environment variables inline
@@ -1,11 +1,8 @@ | |||
--- | |||
- name: Install Xcode v{{ xcode_version }} # noqa: name[template] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[ansible-lint] reported by reviewdog 🐶
command-instead-of-shell Use shell only when shell functionality is required
tasks/Darwin.yml
Outdated
XCODES_USERNAME={{ lookup("env", "CCDC_APPLE_ID_USERNAME") }} \ | ||
XCODES_PASSWORD={{ lookup("env", "CCDC_APPLE_ID_PASSWORD") }} \ | ||
xcodes install {{ xcode_version }} --experimental-unxip --select | ||
ansible.builtin.command: /usr/local/bin/xcodes install {{ xcode_version }} --experimental-unxip --select --use-fastlane-auth |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[yamllint] reported by reviewdog 🐶
[error] trailing spaces (trailing-spaces)
tasks/Darwin.yml
Outdated
XCODES_USERNAME={{ lookup("env", "CCDC_APPLE_ID_USERNAME") }} \ | ||
XCODES_PASSWORD={{ lookup("env", "CCDC_APPLE_ID_PASSWORD") }} \ | ||
xcodes install {{ xcode_version }} --experimental-unxip --select | ||
ansible.builtin.command: /usr/local/bin/xcodes install {{ xcode_version }} --select --use-fastlane-auth |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[yamllint] reported by reviewdog 🐶
[error] trailing spaces (trailing-spaces)
tasks/Darwin.yml
Outdated
creates: "/Applications/Xcode-{{ xcode_version }}.app" | ||
register: install_status | ||
|
||
- debug: var=install_status.stdout |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[ansible-lint] reported by reviewdog 🐶
unnamed-task All tasks should be named
tasks/Darwin.yml
Outdated
export FASTLANE_SESSION="{{ FASTLANE_SESSION }}" | ||
echo $FASTLANE_SESSION >> /tmp/log.txt | ||
echo xcodes install {{ xcode_version }} >> /tmp/log.txt | ||
sudo -E xcodes install {{ xcode_version }} --use-fastlane-auth --aria2 /usr/local/bin/aria2c >> /tmp/log.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[yamllint] reported by reviewdog 🐶
[error] trailing spaces (trailing-spaces)
tasks/Darwin.yml
Outdated
XCODES_PASSWORD={{ lookup("env", "CCDC_APPLE_ID_PASSWORD") }} \ | ||
xcodes install {{ xcode_version }} --experimental-unxip --select | ||
export FASTLANE_SESSION="{{ FASTLANE_SESSION }}" \ | ||
echo $FASTLANE_SESSION >> /tmp/log.txt \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[yamllint] reported by reviewdog 🐶
[error] trailing spaces (trailing-spaces)
tasks/Darwin.yml
Outdated
@@ -1,12 +1,33 @@ | |||
--- | |||
- name: shell test | |||
ansible.builtin.shell: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[yamllint] reported by reviewdog 🐶
[error] trailing spaces (trailing-spaces)
tasks/Darwin.yml
Outdated
- name: shell test | ||
ansible.builtin.shell: | ||
cmd: ls -l | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[yamllint] reported by reviewdog 🐶
[error] trailing spaces (trailing-spaces)
tasks/Darwin.yml
Outdated
|
||
|
||
- name: Downlaod Xcode v{{ xcode_version }} | ||
ansible.builtin.shell: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[yamllint] reported by reviewdog 🐶
[error] trailing spaces (trailing-spaces)
cmd: ls -l | ||
|
||
|
||
- name: Downlaod Xcode v{{ xcode_version }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[ansible-lint] reported by reviewdog 🐶
parser-error conflicting action statements: ansible.builtin.shell, cmd
tasks/Darwin.yml
Outdated
@@ -1,12 +1,31 @@ | |||
--- | |||
- name: shell test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[ansible-lint] reported by reviewdog 🐶
command-instead-of-shell Use shell only when shell functionality is required
tasks/Darwin.yml
Outdated
@@ -1,12 +1,31 @@ | |||
--- | |||
- name: shell test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[ansible-lint] reported by reviewdog 🐶
no-changed-when Commands should not change things if nothing needs doing
tasks/Darwin.yml
Outdated
XCODES_PASSWORD={{ lookup("env", "CCDC_APPLE_ID_PASSWORD") }} \ | ||
xcodes install {{ xcode_version }} --experimental-unxip --select | ||
ansible.builtin.shell: | ||
cmd: /usr/local/bin/xcodes install --path /tmp/xcode-{{ xcode_version }} --experimental-unxip --version {{ xcode_version }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[yamllint] reported by reviewdog 🐶
[error] trailing spaces (trailing-spaces)
tasks/Darwin.yml
Outdated
args: | ||
creates: "/Applications/Xcode_{{ xcode_version }}.app" | ||
creates: /tmp/xcode-{{ xcode-version }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[yamllint] reported by reviewdog 🐶
[error] wrong indentation: expected 4 but found 3 (indentation)
tasks/Darwin.yml
Outdated
args: | ||
creates: "/Applications/Xcode_{{ xcode_version }}.app" | ||
creates: /tmp/xcode-"{{ xcode-version }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[yamllint] reported by reviewdog 🐶
[error] wrong indentation: expected 4 but found 3 (indentation)
tasks/Darwin.yml
Outdated
args: | ||
creates: "/Applications/Xcode_{{ xcode_version }}.app" | ||
creates: /tmp/xcode-"{{ xcode_version }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[yamllint] reported by reviewdog 🐶
[error] wrong indentation: expected 4 but found 3 (indentation)
tasks/Darwin.yml
Outdated
|
||
- name: Set CLI tools path | ||
ansible.builtin.command: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[yamllint] reported by reviewdog 🐶
[error] trailing spaces (trailing-spaces)
tasks/Darwin.yml
Outdated
ansible.builtin.command: | ||
cmd: xcode-select -s /Applications/Xcode-{{ xcode_version }}.app/Contents/Developer | ||
become: true | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[yamllint] reported by reviewdog 🐶
[error] trailing spaces (trailing-spaces)
|
||
- name: Set CLI tools path |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[ansible-lint] reported by reviewdog 🐶
no-changed-when Commands should not change things if nothing needs doing
CI: "true" | ||
JFROG_CLI_OFFER_CONFIG: "false" | ||
args: | ||
creates: /tmp/xcode-{{ xcode_version }}.xip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[yamllint] reported by reviewdog 🐶
[error] wrong indentation: expected 4 but found 3 (indentation)
No description provided.