Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing bm deployment DO-659 #21

Merged
merged 92 commits into from
Apr 15, 2024
Merged
Changes from 90 commits
Commits
Show all changes
92 commits
Select commit Hold shift + click to select a range
b7a3fa0
try command instead of shell DO-659
layfield-ccdc Mar 19, 2024
cf671f2
Update Darwin.yml DO-659
layfield-ccdc Mar 19, 2024
d027bde
try path to xcodes DO-659
layfield-ccdc Mar 19, 2024
ed59afa
changed path DO-659
layfield-ccdc Mar 20, 2024
80976ad
Try using fastlane auth DO-659
layfield-ccdc Mar 20, 2024
cece22b
remove env for users DO-659
layfield-ccdc Mar 20, 2024
fabbb46
set user DO-659
layfield-ccdc Mar 20, 2024
1c0f6bb
update auth and command DO-659
layfield-ccdc Mar 20, 2024
2189f48
remove unzip thing DO-659
layfield-ccdc Mar 20, 2024
628f3b0
changed some bits DO-659
layfield-ccdc Mar 20, 2024
a99e5d2
trying some stuff DO-659
layfield-ccdc Mar 21, 2024
3f404bd
Update Darwin.yml DO-659
layfield-ccdc Mar 21, 2024
cf40198
Update Darwin.yml DO-659
layfield-ccdc Mar 21, 2024
80c80ed
create log DO-659
layfield-ccdc Mar 21, 2024
707f3fe
bring back to basics DO-659
layfield-ccdc Mar 21, 2024
3455537
testing DO-659
layfield-ccdc Mar 21, 2024
8f155d1
more changes DO-659
layfield-ccdc Mar 21, 2024
c095e2a
more testing DO-659
layfield-ccdc Mar 21, 2024
d016549
more changes DO-659
layfield-ccdc Mar 21, 2024
1c64a72
more changes DO-659
layfield-ccdc Mar 21, 2024
6f311d6
removed steps DO-659
layfield-ccdc Mar 21, 2024
a5bd9d9
more changes DO-659
layfield-ccdc Mar 21, 2024
1069546
slight change DO-659
layfield-ccdc Mar 21, 2024
e4bbca0
Update Darwin.yml DO-659
layfield-ccdc Mar 21, 2024
2bab275
Update Darwin.yml
layfield-ccdc Mar 21, 2024
efb567d
Update Darwin.yml DO-659
layfield-ccdc Mar 21, 2024
f4b9b8e
more changes DO-659
layfield-ccdc Mar 21, 2024
fd73b78
try shell again DO-659
layfield-ccdc Mar 21, 2024
bafffdd
Update Darwin.yml DO-659
layfield-ccdc Mar 21, 2024
3303454
Update Darwin.yml DO-659
layfield-ccdc Mar 21, 2024
9d432dc
Update Darwin.yml DO-659
layfield-ccdc Mar 21, 2024
66e8615
set many things DO-659
layfield-ccdc Mar 21, 2024
bb6635f
Update Darwin.yml DO-659
layfield-ccdc Mar 21, 2024
e430814
Update Darwin.yml DO-659
layfield-ccdc Mar 21, 2024
f9a1839
Update Darwin.yml DO-659
layfield-ccdc Mar 21, 2024
9625fe8
Update Darwin.yml DO-659
layfield-ccdc Mar 21, 2024
c23ac55
Update Darwin.yml DO-659
layfield-ccdc Mar 21, 2024
173e26a
Update Darwin.yml
layfield-ccdc Mar 21, 2024
c6086df
Create install-xcodes.sh DO-659
layfield-ccdc Mar 21, 2024
90e8e42
try something new DO-659
layfield-ccdc Mar 21, 2024
8deab7c
Update Darwin.yml
layfield-ccdc Mar 21, 2024
15b3b3b
Update Darwin.yml DO-659
layfield-ccdc Mar 21, 2024
d18cfc1
Update Darwin.yml DO-659
layfield-ccdc Mar 21, 2024
b2481c7
Update Darwin.yml DO-659
layfield-ccdc Mar 21, 2024
1a340cf
Delete files/install-xcodes.sh DO-659
layfield-ccdc Mar 21, 2024
db18f85
Update Darwin.yml DO-659
layfield-ccdc Mar 21, 2024
0c5a7d5
Update Darwin.yml DO-659
layfield-ccdc Mar 22, 2024
9f5d772
Update Darwin.yml DO-659
layfield-ccdc Mar 22, 2024
a4bef36
Update Darwin.yml DO-659
layfield-ccdc Mar 22, 2024
1bfb99d
Update Darwin.yml DO-659
layfield-ccdc Mar 22, 2024
b32dee2
Update Darwin.yml DO-659
layfield-ccdc Mar 22, 2024
97db366
Update Darwin.yml DO-659
layfield-ccdc Mar 22, 2024
cf6f44e
Update Darwin.yml DO-659
layfield-ccdc Mar 22, 2024
6b102d3
Update Darwin.yml DO-659
layfield-ccdc Mar 22, 2024
d41c72f
Update Darwin.yml DO-659
layfield-ccdc Mar 22, 2024
754f949
Update Darwin.yml DO-659
layfield-ccdc Mar 22, 2024
89483d3
Update Darwin.yml
layfield-ccdc Mar 22, 2024
b848c3f
try something DO-659
layfield-ccdc Mar 22, 2024
2610d66
Update Darwin.yml DO-659
layfield-ccdc Mar 22, 2024
b7461a0
Update Darwin.yml DO-659
layfield-ccdc Mar 22, 2024
5df7874
Update Darwin.yml DO-659
layfield-ccdc Mar 22, 2024
d86a75d
Update Darwin.yml DO-659
layfield-ccdc Mar 22, 2024
0f12c32
Update Darwin.yml DO-659
layfield-ccdc Mar 22, 2024
4f93033
Update Darwin.yml DO-659
layfield-ccdc Mar 22, 2024
0aec69c
Update Darwin.yml DO-659
layfield-ccdc Mar 22, 2024
e969aab
prolly works DO-659
layfield-ccdc Mar 22, 2024
05bf8b3
Update Darwin.yml DO-659
layfield-ccdc Mar 22, 2024
cdb952a
Update Darwin.yml DO-659
layfield-ccdc Mar 22, 2024
08e1b76
Update Darwin.yml DO-659
layfield-ccdc Mar 22, 2024
6c347c6
Update Darwin.yml DO-659
layfield-ccdc Mar 22, 2024
6f77493
Update Darwin.yml DO-659
layfield-ccdc Mar 22, 2024
7134497
Update Darwin.yml DO-659
layfield-ccdc Mar 22, 2024
0b1abea
Update Darwin.yml
layfield-ccdc Mar 22, 2024
a6637e6
Update Darwin.yml DO-659
layfield-ccdc Mar 22, 2024
a1a3db7
Update Darwin.yml DO-659
layfield-ccdc Mar 22, 2024
62764b5
Update Darwin.yml DO-659
layfield-ccdc Mar 22, 2024
bef7955
Update Darwin.yml DO-659
layfield-ccdc Mar 22, 2024
dd2c723
Update Darwin.yml
layfield-ccdc Mar 22, 2024
4bf420e
Update Darwin.yml DO-659
layfield-ccdc Mar 22, 2024
1479883
Update Darwin.yml DO-659
layfield-ccdc Mar 26, 2024
9f68b69
Update Darwin.yml DO-659
layfield-ccdc Mar 26, 2024
a978abd
Update Darwin.yml DO-659
layfield-ccdc Mar 26, 2024
bf99fe8
Update Darwin.yml DO-659
layfield-ccdc Mar 26, 2024
0366427
Update Darwin.yml DO-659
layfield-ccdc Mar 26, 2024
e38949b
Update Darwin.yml DO-659
layfield-ccdc Mar 26, 2024
3921af4
Update Darwin.yml DO-659
layfield-ccdc Mar 26, 2024
9e1b87d
more changes DO-659
layfield-ccdc Mar 26, 2024
43a1515
Update Darwin.yml DO-659
layfield-ccdc Mar 26, 2024
69ca58a
Update Darwin.yml DO-659
layfield-ccdc Mar 27, 2024
81bbbfd
Update Darwin.yml DO-659
layfield-ccdc Mar 28, 2024
c437fbc
Merge branch 'main' into layfield-ccdc-patch-1
mmaharjan-ccdc Apr 15, 2024
d82a8db
linting fixes DO-659
layfield-ccdc Apr 15, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 29 additions & 5 deletions tasks/Darwin.yml
Original file line number Diff line number Diff line change
@@ -1,12 +1,36 @@
---
- name: Downlaod Xcode v{{ xcode_version }}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ansible-lint] reported by reviewdog 🐶
no-changed-when Commands should not change things if nothing needs doing

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ansible-lint] reported by reviewdog 🐶
parser-error conflicting action statements: ansible.builtin.shell, cmd

ansible.builtin.shell: >
jf rt dl
--flat
--fail-no-op
--retries=100
--url="https://artifactory.ccdc.cam.ac.uk/artifactory"
--user={{ ansible_deployment_artifactory_user }}
--props="XCODE_VERSION={{ xcode_version }}"
--password="{{ ansible_deployment_artifactory_key }}"
"ccdc-3rdparty-macos-xcode-installers/"
/tmp/xcode-{{ xcode_version }}.xip
environment:
PATH: "/usr/local/bin:/usr/bin"
CI: "true"
JFROG_CLI_OFFER_CONFIG: "false"
args:
creates: /tmp/xcode-{{ xcode_version }}.xip

Check failure on line 19 in tasks/Darwin.yml

View workflow job for this annotation

GitHub Actions / Linting

yaml[indentation]

Wrong indentation: expected 4 but found 3

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[yamllint] reported by reviewdog 🐶
[error] wrong indentation: expected 4 but found 3 (indentation)


- name: Install Xcode v{{ xcode_version }} # noqa: name[template]

Check failure on line 21 in tasks/Darwin.yml

View workflow job for this annotation

GitHub Actions / Linting

command-instead-of-shell

Use shell only when shell functionality is required.

Check notice on line 21 in tasks/Darwin.yml

View workflow job for this annotation

GitHub Actions / ansible-lint

[ansible-lint] tasks/Darwin.yml#L21

command-instead-of-shell Use shell only when shell functionality is required
Raw output
tasks/Darwin.yml:21: command-instead-of-shell Use shell only when shell functionality is required

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ansible-lint] reported by reviewdog 🐶
inline-env-var Command module does not accept setting environment variables inline

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ansible-lint] reported by reviewdog 🐶
command-instead-of-shell Use shell only when shell functionality is required

ansible.builtin.shell: |
XCODES_USERNAME={{ lookup("env", "CCDC_APPLE_ID_USERNAME") }} \
XCODES_PASSWORD={{ lookup("env", "CCDC_APPLE_ID_PASSWORD") }} \
xcodes install {{ xcode_version }} --experimental-unxip --select
ansible.builtin.shell:
cmd: /usr/local/bin/xcodes install {{ xcode_version }} --path /tmp/xcode-{{ xcode_version }}.xip --experimental-unxip
args:
creates: "/Applications/Xcode_{{ xcode_version }}.app"
creates: "/Applications/Xcode-{{ xcode_version }}.app"
environment:
PATH: /usr/local/bin:{{ ansible_env.PATH }}

- name: Set CLI tools path

Check failure on line 29 in tasks/Darwin.yml

View workflow job for this annotation

GitHub Actions / Linting

no-changed-when

Commands should not change things if nothing needs doing.

Check notice on line 29 in tasks/Darwin.yml

View workflow job for this annotation

GitHub Actions / ansible-lint

[ansible-lint] tasks/Darwin.yml#L29

no-changed-when Commands should not change things if nothing needs doing
Raw output
tasks/Darwin.yml:29: no-changed-when Commands should not change things if nothing needs doing

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ansible-lint] reported by reviewdog 🐶
no-changed-when Commands should not change things if nothing needs doing

ansible.builtin.command:

Check failure on line 30 in tasks/Darwin.yml

View workflow job for this annotation

GitHub Actions / Linting

yaml[trailing-spaces]

Trailing spaces

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[yamllint] reported by reviewdog 🐶
[error] trailing spaces (trailing-spaces)

cmd: xcode-select -s /Applications/Xcode-{{ xcode_version }}.app/Contents/Developer
become: true

Check failure on line 33 in tasks/Darwin.yml

View workflow job for this annotation

GitHub Actions / Linting

yaml[trailing-spaces]

Trailing spaces

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[yamllint] reported by reviewdog 🐶
[error] trailing spaces (trailing-spaces)

- name: Accept Xcode licence # noqa: no-changed-when
ansible.builtin.command: xcodebuild -license accept
become: true
Expand Down
Loading