Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workplace Search in Kibana MVP #20

Closed
wants to merge 12 commits into from
Closed

Workplace Search in Kibana MVP #20

wants to merge 12 commits into from

Conversation

scottybollinger
Copy link
Collaborator

@scottybollinger scottybollinger commented Jul 6, 2020 •
edited
Loading

Summary

This PR adds Workplace Search to the Enterprise Search in Kibana MVP

image

QA

Standard auth
For this QA, it works best to log into Enterprise Search first as we have an issue where the #'s in the URLs aren't working when logged out in Rails. Not sure if this is worth the cycles to address before 7.9

  • Workplace Search admin page renders and matches http://localhost:3002/ws#/org
  • Adding a source adds to recent activity at bottom, changes icon to checkmark in onboarding card and updates source count in Usage statistics (custom source is quickest)
  • Adding a user changes icon to checkmark in onboarding card and updates user count in Usage statistics
  • Once source has been added, user has been invited, and org name changed, the onboarding sections (sources, users, and org name) should be hidden.

Native auth
Same as Standard without the users cards

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@scottybollinger scottybollinger marked this pull request as ready for review July 6, 2020 18:01
scottybollinger
scottybollinger commented Jul 6, 2020
View reviewed changes
...prise_search/public/applications/workplace_search/components/overview/organization_stats.tsx
isFederatedAuth ? 'halves' : 'fourths'
}`}
>
<StatisticCard title="Shared sources" count={sourcesCount} actionPath={ORG_SOURCES_PATH} />
Copy link
Collaborator Author

@scottybollinger scottybollinger Jul 6, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no I18n on these titles because EuiCard (found inside the StatisticCard component) only accepts strings as titles

@cee-chen cee-chen self-requested a review July 6, 2020 18:24
@cee-chen cee-chen force-pushed the scottybollinger/feature/workplace_search branch from 57ee018 to 668d4b6 Compare July 6, 2020 18:39
@scottybollinger scottybollinger force-pushed the scottybollinger/feature/workplace_search branch 2 times, most recently from daad478 to ebbc5a3 Compare July 6, 2020 22:35
@cee-chen cee-chen force-pushed the feature/enterprise-search-plugin branch from 5c6e969 to e0909ea Compare July 7, 2020 00:28
@cee-chen cee-chen force-pushed the scottybollinger/feature/workplace_search branch from ebbc5a3 to 4c316ea Compare July 7, 2020 01:10
@cee-chen cee-chen force-pushed the feature/enterprise-search-plugin branch from e0909ea to a615afb Compare July 7, 2020 05:15
@cee-chen cee-chen force-pushed the scottybollinger/feature/workplace_search branch from 4c316ea to f15fc4b Compare July 7, 2020 06:11
@cee-chen cee-chen force-pushed the feature/enterprise-search-plugin branch from a615afb to 3db3881 Compare July 7, 2020 07:45
scottybollinger and others added 12 commits July 7, 2020 00:46
@scottybollinger @cee-chen
Add Workplace Search plugin to app
7043049 
- Adds telemetry for Workplace Search
- Adds routing for telemetry and overview
- Registers plugin
@scottybollinger @cee-chen
Add breadcrumbs for Workplace Search
2e2ced4
@scottybollinger @cee-chen
Add Workplace Search index
ea16e2d
@scottybollinger @cee-chen
Add route paths, types and shared assets
348edd8
@scottybollinger @cee-chen
Add shared Workplace Search components
a9502d9
@scottybollinger @cee-chen
Add setup guide to Workplace Search
f2350d1
@scottybollinger @cee-chen
Add error state to Workplace Search
ea2c917
@scottybollinger @cee-chen
Add Workplace Search overview
124988a 
This is the functional MVP for Workplace Search
@cee-chen
Update telemetry per recent changes
2834baa 
- Remove saved objects indexing
- add schema definition
- remove no_ws_account
- minor cleanup
@scottybollinger @cee-chen
Fix pluralization syntax
bfd49da 
- Still not working but fixed the syntax nonetheless
@scottybollinger @cee-chen
Change pluralization method
52e100d 
- Was unable to get the `FormattedMessage` to work using the syntax in the docs. Always added ‘more’, even when there were zero (or one for users). This commit uses an alternative approach that works
@cee-chen
Update to account for access/feature control test fixes
5cae7a1
@cee-chen cee-chen force-pushed the scottybollinger/feature/workplace_search branch from f15fc4b to 5cae7a1 Compare July 7, 2020 08:04
@cee-chen
Copy link
Owner

cee-chen commented Jul 7, 2020

Closing in favor of #22

@cee-chen cee-chen closed this Jul 7, 2020
@cee-chen cee-chen deleted the scottybollinger/feature/workplace_search branch July 7, 2020 21:24
@cee-chen cee-chen mentioned this pull request Jul 10, 2020
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cee-chen cee-chen Awaiting requested review from cee-chen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scottybollinger @cee-chen