Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update error message for Blocked params #1705

Closed
evan-forbes opened this issue May 5, 2023 · 0 comments · Fixed by #1709
Closed

Update error message for Blocked params #1705

evan-forbes opened this issue May 5, 2023 · 0 comments · Fixed by #1709
Labels
good first issue Good for newcomers

Comments

@evan-forbes
Copy link
Member 

var ErrBlockedParameter = sdkerrors.Register(ModuleName, baseErrorCode, "parameter can not be modified")

nit: I think the words hard fork required could spook a few users

Originally posted by @cmwaters in #1694 (comment)

we should update the error message for blocked params as described above
@evan-forbes evan-forbes mentioned this issue May 5, 2023
Merged
5 tasks
@rootulp rootulp added good first issue Good for newcomers and removed needs:triage labels May 5, 2023
@NishantKoyalwar NishantKoyalwar mentioned this issue May 5, 2023
Merged
5 tasks
rootulp pushed a commit that referenced this issue May 8, 2023
@NishantKoyalwar
chore: improve error message for blocked params (#1709)
e223493 
<!--
Please read and fill out this form before submitting your PR.

Please make sure you have reviewed our contributors guide before
submitting your
first PR.
-->

## Overview

- updated err message to 
``` go
var ErrBlockedParameter = sdkerrors.Register(ModuleName, baseErrorCode, "parameter can not be modified")
```
- closes #1705

<!-- 
Please provide an explanation of the PR, including the appropriate
context,
background, goal, and rationale. If there is an issue with this
information,
please provide a tl;dr and link the issue. 
-->

## Checklist

<!-- 
Please complete the checklist to ensure that the PR is ready to be
reviewed.

IMPORTANT:
PRs should be left in Draft until the below checklist is completed.
-->

- [ ] New and updated code has appropriate documentation
- [ ] New and updated code has new and/or updated testing
- [ ] Required CI checks are passing
- [ ] Visual proof for any user facing features like CLI or
documentation updates
- [x] Linked issues closed with keywords
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: improve error message for blocked params NishantKoyalwar/celestia-app
2 participants
@rootulp @evan-forbes