chore: improve error message for blocked params

[NishantKoyalwar]

Overview

• updated err message to

var ErrBlockedParameter = sdkerrors.Register(ModuleName, baseErrorCode, "parameter can not be modified")

• closes Update error message for Blocked params #1705

Checklist

• New and updated code has appropriate documentation
• New and updated code has new and/or updated testing
• Required CI checks are passing
• Visual proof for any user facing features like CLI or documentation updates
• Linked issues closed with keywords

[evan-forbes]

thanks @NishantKoyalwar !

[evan-forbes]

the CI will break cause we hardcoded a test, so we should also update

celestia-app/x/paramfilter/test/param_filter_test.go

Line 54 in 2dc35d9

require.Contains(t, err.Error(), "blocked parameter change")

[codecov-commenter]

Codecov Report

Merging #1709 (86ffcb5) into main (2dc35d9) will decrease coverage by 0.14%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1709      +/-   ##
==========================================
- Coverage   52.71%   52.58%   -0.14%     
==========================================
  Files          97       97              
  Lines        6269     6278       +9     
==========================================
- Hits         3305     3301       -4     
- Misses       2631     2644      +13     
  Partials      333      333              

see 1 file with indirect coverage changes

[gitpoap-bot]

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2023 Celestia Contributor:

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.