chore: cherry pick default changes #1099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Supersedes celestiaorg/celestia-core#885 Closes celestiaorg/celestia-core#812 Closes celestiaorg/celestia-core#867 Closes #590
Addresses #669 (comment) by copying the consensus config overrides from celestiaorg/cosmos-sdk. This PR should be merged in parallel with celestiaorg/cosmos-sdk#284 Co-authored-by: Evan Forbes <42654277+evan-forbes@users.noreply.github.com>
evan-forbes
changed the title
Codecov Report
@@ Coverage Diff @@
## v0.10.x #1099 +/- ##
==========================================
Coverage ? 26.12%
==========================================
Files ? 77
Lines ? 9361
Branches ? 0
==========================================
Hits ? 2446
Misses ? 6684
Partials ? 231 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
YazzyYaz
approved these changes
Dec 8, 2022
rootulp
approved these changes
Dec 8, 2022
## Overview update the min fee to something non zero ## Checklist - [x] New and updated code has appropriate documentation - [x] New and updated code has new and/or updated testing - [x] Required CI checks are passing - [x] Visual proof for any user facing features like CLI or documentation updates - [x] Linked issues closed with keywords
|
forgot about the min fee! added in d108b2e |
rootulp
approved these changes
Dec 9, 2022
cmwaters
approved these changes
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
cherry-picks default changes closes #1094
Checklist