Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci/check-size): use latest non-merge commit #72

Merged
merged 1 commit into from
Jun 17, 2023

Conversation

snprajwal
Copy link
Member

We were previously using the merge commit as the baseline, leading to all commits from the pull request being rebased, rather than just the latest commit.

We were previously using the merge commit as the baseline, leading to
all commits from the pull request being rebased, rather than just the
latest commit.

Signed-off-by: Prajwal S N <prajwalnadig21@gmail.com>
@github-actions
Copy link

Test Results

24 tests  ±0   24 ✔️ ±0   0s ⏱️ ±0s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ±0 

Results for commit d054676. ± Comparison against base commit 5bb5902.

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (5bb5902) 79.81% compared to head (d054676) 79.81%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #72   +/-   ##
=======================================
  Coverage   79.81%   79.81%           
=======================================
  Files           3        3           
  Lines         436      436           
=======================================
  Hits          348      348           
  Misses         65       65           
  Partials       23       23           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@adrianreber adrianreber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@rst0git PTAL

@rst0git rst0git merged commit d91aab9 into checkpoint-restore:main Jun 17, 2023
@snprajwal snprajwal deleted the fix-ci branch July 12, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants