File log devices opened by mixlib-log should be closed. #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def loggers_to_close | ||
| loggers_to_close = [] | ||
| all_loggers.each do |logger| | ||
| next unless logdev = logger.instance_variable_get(:"@logdev") |
There was a problem hiding this comment.
This seems like a bad idea. Needs a hell of a justification as a comment at least.
|
I have addeed comment to the code explaining the "bad idea". |
Ruby does not have a destructor concept so the opened files should be closed explicitely. The ruby logger which is used as a default logger here does not close logdevices it opened until #close method is called. When #rest! happens the logger instance gets destroyed but the #close method is not triggered. This patch should help to solve the problem described here: chef/chef#3435
|
I have just rebased branch on latest master and make PR ready to be merged. |
|
👍 |
|
Seems like a reasonable thing to do. @chef/client-core review? |
|
👍 |
1 similar comment
|
👍 |
| def close! | ||
| # try to close all file loggers | ||
| loggers_to_close.each do |l| | ||
| l.close rescue nil |
There was a problem hiding this comment.
Could we output any rescued errors to stderr? Seems like that would be nice for troubleshooting purposes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby does not have a destructor concept so the opened files should be closed explicitly.
The Ruby Logger which is used as a default logger here does not close log devices it opened until #close method is called. When #rest! happens the logger instance gets destroyed but the #close method
is not triggered.
This patch should help to solve the problem described here: chef/chef#3435