Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File log devices opened by mixlib-log should be closed. #13

Merged
merged 4 commits into from
Aug 3, 2016
Merged

File log devices opened by mixlib-log should be closed. #13

merged 4 commits into from
Aug 3, 2016

Commits on Mar 18, 2016

  1. File log devices opened by mixlib-log should be closed. 

    Ruby does not have a destructor concept so the opened files should be closed explicitely. The ruby logger which is used as a default logger
here does not close logdevices it opened until #close method is called. When #rest! happens the logger instance gets destroyed but the #close method
is not triggered.
This patch should help to solve the problem described here: chef/chef#3435
    @mhorbul
    mhorbul committed Mar 18, 2016
    Configuration menu
    Copy the full SHA
    32b53a2 View commit details
    Browse the repository at this point in the history

  2. add comment to the shady code

    @mhorbul
    mhorbul committed Mar 18, 2016
    Configuration menu
    Copy the full SHA
    1abc84f View commit details
    Browse the repository at this point in the history

  3. clean up warnings related to the old rspec syntax

    @mhorbul
    mhorbul committed Mar 18, 2016
    Configuration menu
    Copy the full SHA
    b122bcc View commit details
    Browse the repository at this point in the history

  4. make travis-ci happy

    @mhorbul
    mhorbul committed Mar 18, 2016
    Configuration menu
    Copy the full SHA
    833e12b View commit details
    Browse the repository at this point in the history