Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(flagging): add pipeline task for rainfall flagging #244

Merged
merged 1 commit into from
May 13, 2024
Merged

Conversation

sjforeman
Copy link
Contributor

New pipeline task to mask time samples after rainy periods, intended to replace the usage of rain1mm and rain1mm_sd flags from the database. The task computes the accumulated rainfall N hours prior to each time sample in a timestream or sidereal stream, and sets the weights to zero if the rainfall total exceeds some threshold (in mm). The user can specify N and the threshold.

ljgray
ljgray previously approved these changes May 10, 2024
Copy link
Contributor

@ljgray ljgray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. A couple of minor comments

ch_pipeline/analysis/flagging.py Outdated Show resolved Hide resolved
ch_pipeline/analysis/flagging.py Outdated Show resolved Hide resolved
ch_pipeline/analysis/flagging.py Outdated Show resolved Hide resolved
@ljgray ljgray merged commit 375ebcc into master May 13, 2024
2 checks passed
@ljgray ljgray deleted the sf/rainfall branch May 13, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants