-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Daily Pipeline rev_08 Config #229
Conversation
BeamFormCat
tasks
66accf4
to
6e56a69
Compare
BeamFormCat
tasks6e56a69
to
5a88e55
Compare
Suggested changes for updated rainfall flagging:
|
5a88e55
to
de24c26
Compare
Done |
de24c26
to
8e3dfc6
Compare
The new data quality metric and rfi mask introduced in #246 and draco #268 be incorporated into the configuration file as follows:
Although we have to make a copy of the timestream in order to filter it, which could potentially cause memory issues. |
Looks good, I'll test it out. I have a feeling that we will end up having memory issues. If we do, how much more computationally expensive would it be to do the delay filter for all baselines and then add a min/max baseline length parameter to |
Ah never mind, I see now that the dayenu filter is applied in place |
Yeah exactly. I think if it was an issue, then we could just create a single task that does everything (baseline masking, filtering, and sum over the stack axis). It would do this for each time sample and then output a (freq, time) container for masking. |
@ssiegelx I tested with the standard pipeline config and it did unfortunately produce a memory error during If it's straightforward to combine the tasks then that would probably be the best way to go. I can also try increasing the number of nodes per pipeline job to 16, but with our lower allocation this year it wouldn't be ideal |
Ok thanks! I'll combine the tasks. I think I should have something by tomorrow. |
The updated task has been pushed to draco #268. I am still waiting to get a test job to run. The config should now look like:
|
a889ba6
to
09319ac
Compare
8b172b8
to
c5b9183
Compare
f581f76
to
1bc36aa
Compare
c61be01
to
fa4bdbb
Compare
2c06f62
to
3fe6bc9
Compare
4cf8781
to
103a11b
Compare
…ounds in FlagRainfall
103a11b
to
313c64f
Compare
Updated RFI masking
RFIStokesIMask
task, with significant improvements to RFI flaggingSidereal rebinning
Uses the new
SiderealRebinner
task in place of regridding, which is significantly simpler than the previous regridding task and eliminates the artifacts introduced at this stage. Also removes theThresholdVisWeightBaseline
task which was required to remove regridding artifacts.The rebinning process results in a difference between the true and effective RA bin centres, so a correction is required. On the daily level, a local gradient is calculated based on a stack dataset with full sidereal and frequency coverage. This correction will be applied after stacking when producing a stack from this data.
Restrict run order for
BeamFormCat
tasksSlightly modifies the run order around
BeamFormCat
tasks. This task can store a large copy of the sidereal stream data in itssetup
method, so these changes try to (a) block the setup from happening untilnext
can run right afterwards and (b) restrict the number of outputs based on the number of catalogs being loaded so that the task moves to itsfinish
state as soon as the last iteration is done.Fixes and improvements to file online/offline management
Properly manage weather files, flag checks, and file pad lag.
Dependencies