Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a new RFI Flagging task #265

Merged
merged 4 commits into from
May 21, 2024
Merged

Add a new RFI Flagging task #265

merged 4 commits into from
May 21, 2024

Conversation

ljgray
Copy link
Contributor

@ljgray ljgray commented Apr 12, 2024 •
edited
Loading

Adds a new RFI mask and a couple of extra tools

RFI Mask

2-stage RFI mask

  • high-pass m filter to isolate transient rfi
  • low-pass m filter and sum threshold over frequencies to isolate narrowband rfi

Additional Tools

  • Update null_delay_filter to optionally low or high pass
  • Add a task to taper a 2D mask
  • Add a task to calculate a baseline estimate for a 1D spectrum in the presence of outliers. Works quite well - too computationally expensive to extend to 2D so I didn't end up using it in the RFI filter This might not actually be true - going to investigate

@ljgray ljgray force-pushed the ljg/rfi-mask-hpf branch 2 times, most recently from c03b2fa to 35f1c04 Compare April 12, 2024 23:04
@ljgray ljgray force-pushed the ljg/rfi-mask-hpf branch 3 times, most recently from 52833eb to d99c5e6 Compare May 1, 2024 21:50
@ljgray ljgray marked this pull request as ready for review May 3, 2024 18:02
@ljgray ljgray requested review from sjforeman and ssiegelx May 3, 2024 18:03
This was referenced May 3, 2024
Merged
Merged
sjforeman
sjforeman approved these changes May 12, 2024
View reviewed changes
Copy link
Contributor

@sjforeman sjforeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looking good - just a few places where more explanation would be useful

draco/analysis/delay.py Outdated Show resolved Hide resolved
draco/util/tools.py Outdated Show resolved Hide resolved
draco/util/tools.py Outdated Show resolved Hide resolved
draco/util/tools.py Show resolved Hide resolved
draco/util/tools.py Show resolved Hide resolved
draco/analysis/flagging.py Outdated Show resolved Hide resolved
draco/analysis/flagging.py Outdated Show resolved Hide resolved
draco/analysis/flagging.py Show resolved Hide resolved
@ljgray ljgray force-pushed the ljg/rfi-mask-hpf branch 2 times, most recently from 7b84652 to 1b09ebb Compare May 13, 2024 23:02
@ljgray ljgray requested a review from sjforeman May 13, 2024 23:31
@ssiegelx ssiegelx mentioned this pull request May 14, 2024
Merged
sjforeman
sjforeman approved these changes May 19, 2024
View reviewed changes
draco/util/tools.py Outdated Show resolved Hide resolved
@ljgray
feat(tools): add least squares baseline fit and mask taper functions.
91cfd75 
arPLS - 1D penalized least squares fit. Better than weighted median.

taper_mask: apply a hanning taper along the second axis of a 2D mask
@ljgray
feat(flagging): add a new Stokes I RFI mask
2dd4b0d 
Apply a high-pass m filter to isolate scattered emission, then apply
a sumthreshold mask to the average low-m power over longer baselines.
@ljgray ljgray merged commit 5691515 into master May 21, 2024
4 checks passed
@ljgray ljgray deleted the ljg/rfi-mask-hpf branch May 21, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjforeman sjforeman sjforeman approved these changes

@ssiegelx ssiegelx Awaiting requested review from ssiegelx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ljgray @sjforeman