Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action needed email editor breaks resize, and throws a reference error #2651

Closed
rachidatecs opened this issue Aug 26, 2024 · 2 comments · Fixed by #2713
Closed

Action needed email editor breaks resize, and throws a reference error #2651

rachidatecs opened this issue Aug 26, 2024 · 2 comments · Fixed by #2713
Assignees
Labels
bug Something that isn't working as intended carryover Carryover from a previous sprint dev Feature: 🧮 Analyst Experience

Comments

@rachidatecs
Copy link
Contributor

rachidatecs commented Aug 26, 2024

Current Behavior

The admin action needed email editor can be resized past the browser's right edge. It also does not resize responsively when shrinking the window's width.

Additionally, it is also throwing a javascript error, Uncaught ReferenceError: editEmailButton is not defined on page load

Expected Behavior

  1. The textarea should behave like a responsive item, and the field should behave normally
  2. The action needed email should no longer return a reference error
  3. The text of the action needed reason field automatically updates when changing reasons

Steps to Reproduce

Resize bug:

  1. Log into admin, resize the textarea for action needed email past the browser's edge.
  2. Refresh
  3. Shrink down the browser window

Javascript bug:

  1. Select a request that is not "action needed"
  2. Change the status to action needed
  3. Note that the reason does not update automatically (check console)

Environment

No response

Additional Context

One other minor improvement should be made when working on this. Per @AnnaGingle:

The ANDI output for the (noneditable) Email: field should be Email:.

Additionally, when the Email: field is in edit mode the ANDI output is Email: but it should be Email: | This email will be sent to the creator of this request after saving.

I cannot get to a state where the email has been sent but the ANDI output should be: Email: | This email has been sent to the creator of the request

Issue Links

blocks:

@rachidatecs rachidatecs added the bug Something that isn't working as intended label Aug 26, 2024
@abroddrick abroddrick self-assigned this Aug 26, 2024
@abroddrick
Copy link
Contributor

Assigning to myself to refine

@rachidatecs
Copy link
Contributor Author

Per huddle and conversation with @gabydisarli, the design can be tweaked a bit so that the label on the left is dynamic and the content in the right column are the edit button and the un-styled textbox.

@abroddrick abroddrick assigned rachidatecs and unassigned abroddrick Aug 27, 2024
@zandercymatics zandercymatics changed the title Action needed email editor breaks on resize / screen resize Action needed email editor breaks on resize / screen resize and other bugs Aug 28, 2024
@zandercymatics zandercymatics changed the title Action needed email editor breaks on resize / screen resize and other bugs Action needed email editor breaks resize, and throws a reference error Aug 28, 2024
@vickyszuchin vickyszuchin added the carryover Carryover from a previous sprint label Sep 20, 2024
zandercymatics added a commit that referenced this issue Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that isn't working as intended carryover Carryover from a previous sprint dev Feature: 🧮 Analyst Experience
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

6 participants
@rachidatecs @abroddrick @zandercymatics @vickyszuchin and others