-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow use of BackboneMixin without arguments; fix controlled components and changing models #18
Allow use of BackboneMixin without arguments; fix controlled components and changing models #18
Conversation
this is already checked in the guard
was redundant with documented code
changeOptions should only be declared once
to make style consistent with subscribe/unsubscribe, which use similar constructs for checking preconditions
This way we will be able to mixin multiple times
also added use strict to ensure this won't happen again
used parameters instead of binding to this. Thanks to @EamonNerbonne for the suggestion
Also kept createBackboneClass backwards compatible
👍 |
This is great - @markijbema did you ever revisit this? #15 (comment) |
No sorry, didn't get around to doing that yet. |
However, I just did :-) Behavior is slightly tricky (backwards compat often is, alas): change options are now those customized if available, otherwise the component (spec's) |
👍 this was exactly what I wanted to do, thanks @EamonNerbonne ! |
It is done! Thank you both very much for all the work, apologies for the extraordinarily long delay 👏 |
This PR builds on @markijbema's #15.
It fixes two subtle bugs:
It also supports using BackboneMixin without arguments.