Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow use of BackboneMixin without arguments; fix controlled components and changing models #18

Merged
merged 21 commits into from
Apr 16, 2014
Merged

Allow use of BackboneMixin without arguments; fix controlled components and changing models #18

merged 21 commits into from
Apr 16, 2014

Commits on Mar 12, 2014

  1. Removed unneeded check 

    this is already checked in the guard
    @markijbema
    markijbema committed Mar 12, 2014
    Configuration menu
    Copy the full SHA
    f398a6c View commit details
    Browse the repository at this point in the history

  2. Removed comment 

    was redundant with documented code
    @markijbema
    markijbema committed Mar 12, 2014
    Configuration menu
    Copy the full SHA
    69dff40 View commit details
    Browse the repository at this point in the history

  3. Fixed warning 

    changeOptions should only be declared once
    @markijbema
    markijbema committed Mar 12, 2014
    Configuration menu
    Copy the full SHA
    6c36b22 View commit details
    Browse the repository at this point in the history

  4. Fixed syntax

    @markijbema
    markijbema committed Mar 12, 2014
    Configuration menu
    Copy the full SHA
    c308c34 View commit details
    Browse the repository at this point in the history

  5. Use guard instead of if 

    to make style consistent with subscribe/unsubscribe,
which use similar constructs for checking preconditions
    @markijbema
    markijbema committed Mar 12, 2014
    Configuration menu
    Copy the full SHA
    1f37283 View commit details
    Browse the repository at this point in the history

  6. Make sure throttled forceUpdate does not fire after unmount

    @markijbema
    markijbema committed Mar 12, 2014
    Configuration menu
    Copy the full SHA
    591c180 View commit details
    Browse the repository at this point in the history

  7. Unify how we do forceupdates for collections and models

    @markijbema
    markijbema committed Mar 12, 2014
    Configuration menu
    Copy the full SHA
    ca9d26a View commit details
    Browse the repository at this point in the history

  8. Extracted some functionality out of subscribe into local functions

    @markijbema
    markijbema committed Mar 12, 2014
    Configuration menu
    Copy the full SHA
    b29667c View commit details
    Browse the repository at this point in the history

  9. Don't define subscribe and unsubscribe on the object anymore 

    This way we will be able to mixin multiple times
    @markijbema
    markijbema committed Mar 12, 2014
    Configuration menu
    Copy the full SHA
    dc1bdd0 View commit details
    Browse the repository at this point in the history

  10. Handle the view helpers as mixin as well

    @markijbema
    markijbema committed Mar 12, 2014
    Configuration menu
    Copy the full SHA
    b302a04 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2014

  1. made variables private 

    also added use strict to ensure this won't happen again
    @markijbema
    markijbema committed Mar 19, 2014
    Configuration menu
    Copy the full SHA
    f396ce1 View commit details
    Browse the repository at this point in the history

  2. Made binding simpler 

    used parameters instead of binding to this. Thanks to @EamonNerbonne for
the suggestion
    @markijbema
    markijbema committed Mar 19, 2014
    Configuration menu
    Copy the full SHA
    fc18d47 View commit details
    Browse the repository at this point in the history

  3. Make the mixin parameterized 

    Also kept createBackboneClass backwards compatible
    @markijbema
    markijbema committed Mar 19, 2014
    Configuration menu
    Copy the full SHA
    97ca1c6 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2014

  1. Fixed readme

    @markijbema
    markijbema committed Mar 24, 2014
    Configuration menu
    Copy the full SHA
    debcbd5 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2014

  1. Check whether we're dealing with a model vs. collection to know to de… 

    …bounce
    @EamonNerbonne
    EamonNerbonne committed Apr 15, 2014
    Configuration menu
    Copy the full SHA
    c8aa8f3 View commit details
    Browse the repository at this point in the history

  2. Extract debouncing logic with change options into a behavior object

    @EamonNerbonne
    EamonNerbonne committed Apr 15, 2014
    Configuration menu
    Copy the full SHA
    fc601c3 View commit details
    Browse the repository at this point in the history

  3. Fix subscribing when models change

    @EamonNerbonne
    EamonNerbonne committed Apr 15, 2014
    Configuration menu
    Copy the full SHA
    4f5b9ca View commit details
    Browse the repository at this point in the history

  4. Minor: shorten code using underscore

    @EamonNerbonne
    EamonNerbonne committed Apr 15, 2014
    Configuration menu
    Copy the full SHA
    a21a4e9 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2014

  1. Indent per react.backbone coding style

    @EamonNerbonne
    EamonNerbonne committed Apr 16, 2014
    Configuration menu
    Copy the full SHA
    2b459a4 View commit details
    Browse the repository at this point in the history

  2. Use components changeOptions if available

    @EamonNerbonne
    EamonNerbonne committed Apr 16, 2014
    Configuration menu
    Copy the full SHA
    c312426 View commit details
    Browse the repository at this point in the history

  3. BackboneMixin without params: old behavior

    @EamonNerbonne
    EamonNerbonne committed Apr 16, 2014
    Configuration menu
    Copy the full SHA
    1874223 View commit details
    Browse the repository at this point in the history