-
Notifications
You must be signed in to change notification settings - Fork 52
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix accidental 4.0 breaking changes and run example in CI (#68)
This addresses two accidental breaking changes: 1. Introduced in #14: Config deserialization previously expected log level to be all caps (e.g., "TRACE", matching [slog](https://docs.rs/slog/latest/src/slog/lib.rs.html#2079)), but are now expected to be lowercase (since foundations adds the serde attribute `rename_all="snake_case"` to enums). So deserialization of existing configs would break 2. Introduced in #54: If an app has the "memory-profiling" feature enabled, but the settings disable memory profiling, server init would fail because the returned profiler would be None This also adds adds a step to CI that does a "dry run" of the example to validate the example config, to help catch breaking config changes going forward
- Loading branch information
Showing
4 changed files
with
37 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters