Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix accidental 4.0 breaking changes and run example in CI #68

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

OmegaJak
Copy link
Contributor

@OmegaJak OmegaJak commented Oct 1, 2024

This addresses two accidental breaking changes:

  1. Introduced in telemetry: change LogVerbosity to an enum, use it throughout public API #14: Config deserialization previously expected log level to be all caps (e.g., "TRACE", matching slog), but are now expected to be lowercase (since foundations adds the serde attribute rename_all="snake_case" to enums). So deserialization of existing configs would break
  2. Introduced in ZTC-1648: Avoid heap profiling crash by eagerly starting long-lived profiling thread #54: If an app has the "memory-profiling" feature enabled, but the settings disable memory profiling, server init would fail because the returned profiler would be None

This also adds adds a step to CI that does a "dry run" of the example to validate the example config, to help catch breaking config changes going forward

@nmldiegues nmldiegues merged commit f3bfb54 into cloudflare:main Oct 1, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants