Skip to content

Commit

Permalink
refactor: support backwards compatibility with environment names and …
Browse files Browse the repository at this point in the history
…related CLI flags (#680)

1. When in Legacy environment mode we should not compute name field if specified in an environment.
2. Throw an Error when `--env` and `--name` are used together in Legacy Environment, except for Secrets & Tail which are using a special case `getLegacyScriptName` for parity with Wrangler1
3. Started the refactor for args being utilized at the Config level, currently checking for Legacy Environment only.

Fixes #672
  • Loading branch information
JacobMGEvans committed Mar 23, 2022
1 parent 82e4143 commit 8e2cbaf
Show file tree
Hide file tree
Showing 7 changed files with 370 additions and 142 deletions.
11 changes: 11 additions & 0 deletions .changeset/swift-apes-battle.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
---
"wrangler": patch
---

refactor: support backwards compatibility with environment names and related CLI flags

1. When in Legacy environment mode we should not compute name field if specified in an environment.
2. Throw an Error when `--env` and `--name` are used together in Legacy Environment, except for Secrets & Tail which are using a special case `getLegacyScriptName` for parity with Wrangler1
3. Started the refactor for args being utilized at the Config level, currently checking for Legacy Environment only.

Fixes https://github.com/cloudflare/wrangler2/issues/672
Loading

0 comments on commit 8e2cbaf

Please sign in to comment.