Support backwards compatibility with environment names and related CLI flags #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacobMGEvans
force-pushed
the
jacobmgevans/legacy-env-name
branch
from
27439c9
to
8cf45c2
Compare
🦋 Changeset detectedLatest commit: 50cfa2b The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…related CLI flags 1. When in Legacy environment mode we should not compute name field if specified in an environment. 2. Throw an Error when `--env` and `--name` are used together in Legacy Environment, except for Secrets & Tail which are using a special case `getLegacyScriptName` for parity with Wrangler1 3. Started the refactor for args being utilized at the Config level, currently checking for Legacy Environment only. Fixes #672
JacobMGEvans
force-pushed
the
jacobmgevans/legacy-env-name
branch
from
8cf45c2
to
50cfa2b
Compare
petebacondarwin
approved these changes
Mar 23, 2022
Merged
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2029542841/npm-package-wrangler-680You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/680/npm-package-wrangler-680Or you can use npx https://prerelease-registry.developers.workers.dev/runs/2029542841/npm-package-wrangler-680 dev path/to/script.js |
|
This is breaking environments right now. In legacy mode, names do not have |
petebacondarwin
added a commit
to petebacondarwin/wrangler2
that referenced
this pull request
Mar 28, 2022
When a developer uses `--env` to specify an environment name, the Worker name should be computed from the top-level Worker name and the environment name. When the given environment name does not match those in the wrangler.toml, we error. But if no environments have been specified in the wrangler.toml, at all, then we only log a warning and continue. In this second case, we were reusing the top-level environment, which did not have the correct legacy environment fields set, such as the name. Now we ensure that such an environment is created as needed. See cloudflare#680 (comment)
petebacondarwin
added a commit
to petebacondarwin/wrangler2
that referenced
this pull request
Mar 28, 2022
When a developer uses `--env` to specify an environment name, the Worker name should be computed from the top-level Worker name and the environment name. When the given environment name does not match those in the wrangler.toml, we error. But if no environments have been specified in the wrangler.toml, at all, then we only log a warning and continue. In this second case, we were reusing the top-level environment, which did not have the correct legacy environment fields set, such as the name. Now we ensure that such an environment is created as needed. See cloudflare#680 (comment)
petebacondarwin
added a commit
to petebacondarwin/wrangler2
that referenced
this pull request
Mar 28, 2022
When a developer uses `--env` to specify an environment name, the Worker name should be computed from the top-level Worker name and the environment name. When the given environment name does not match those in the wrangler.toml, we error. But if no environments have been specified in the wrangler.toml, at all, then we only log a warning and continue. In this second case, we were reusing the top-level environment, which did not have the correct legacy environment fields set, such as the name. Now we ensure that such an environment is created as needed. See cloudflare#680 (comment)
threepointone
pushed a commit
that referenced
this pull request
Mar 28, 2022
…ts (#719) When a developer uses `--env` to specify an environment name, the Worker name should be computed from the top-level Worker name and the environment name. When the given environment name does not match those in the wrangler.toml, we error. But if no environments have been specified in the wrangler.toml, at all, then we only log a warning and continue. In this second case, we were reusing the top-level environment, which did not have the correct legacy environment fields set, such as the name. Now we ensure that such an environment is created as needed. See #680 (comment)
mrbbot
added a commit
that referenced
this pull request
Oct 31, 2023
We previously waited for Miniflare to be ready before `dispose()`ing. Unfortunately, we weren't waiting for the `workerd` config to finish being written to stdin. Calling `dispose()` immediately after `new Miniflare()` would stop waiting for socket ports to be reported, and kill the `workerd` process while data was still being written. This threw an unhandled `EPIPE` error. This changes makes sure we don't report that Miniflare is ready until after the config is fully-written. Closes #680
mrbbot
added a commit
that referenced
this pull request
Nov 1, 2023
We previously waited for Miniflare to be ready before `dispose()`ing. Unfortunately, we weren't waiting for the `workerd` config to finish being written to stdin. Calling `dispose()` immediately after `new Miniflare()` would stop waiting for socket ports to be reported, and kill the `workerd` process while data was still being written. This threw an unhandled `EPIPE` error. This changes makes sure we don't report that Miniflare is ready until after the config is fully-written. Closes #680
mrbbot
added a commit
that referenced
this pull request
Nov 1, 2023
We previously waited for Miniflare to be ready before `dispose()`ing. Unfortunately, we weren't waiting for the `workerd` config to finish being written to stdin. Calling `dispose()` immediately after `new Miniflare()` would stop waiting for socket ports to be reported, and kill the `workerd` process while data was still being written. This threw an unhandled `EPIPE` error. This changes makes sure we don't report that Miniflare is ready until after the config is fully-written. Closes #680
mrbbot
added a commit
that referenced
this pull request
Nov 1, 2023
We previously waited for Miniflare to be ready before `dispose()`ing. Unfortunately, we weren't waiting for the `workerd` config to finish being written to stdin. Calling `dispose()` immediately after `new Miniflare()` would stop waiting for socket ports to be reported, and kill the `workerd` process while data was still being written. This threw an unhandled `EPIPE` error. This changes makes sure we don't report that Miniflare is ready until after the config is fully-written. Closes #680
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--envand--nameare used together in Legacy Environment, except for Secrets & Tail which are using a special casegetLegacyScriptNamefor parity with Wrangler1Fixes #672