Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT: --asset should resolve relative to cwd, not wrangler.toml #1333

Closed
JacobMGEvans opened this issue Jun 22, 2022 · 0 comments · Fixed by #1335 or #1336
Closed

FEAT: --asset should resolve relative to cwd, not wrangler.toml #1333

JacobMGEvans opened this issue Jun 22, 2022 · 0 comments · Fixed by #1335 or #1336
Assignees
@JacobMGEvans
Labels
bug Something that isn't working polish Small improvements to the experience

Comments

@JacobMGEvans
Copy link
Contributor

What version of Wrangler are you using?

2.0.15

What operating system are you using?

Mac

Describe the Bug

We resolve the Asset directory relative to the location of wrangler.toml. We probably shouldn't do that when the bucket is passed via --asset, it should resolve relative to process.cwd().
@JacobMGEvans JacobMGEvans added polish Small improvements to the experience bug Something that isn't working labels Jun 22, 2022
@JacobMGEvans JacobMGEvans self-assigned this Jun 22, 2022
@JacobMGEvans JacobMGEvans changed the title 🐛 BUG: --asset should resolve relative to cwd, not wrangler.toml FEAT: --asset should resolve relative to cwd, not wrangler.toml Jun 22, 2022
@JacobMGEvans JacobMGEvans mentioned this issue Jun 22, 2022
Merged
JacobMGEvans added a commit that referenced this issue Jun 22, 2022
@JacobMGEvans
feat: resolve cli arg relative to current working directory
d41aa1d 
Before we were resolving the Asset directory relative to the location of  at all times.
Now the  cli arg is resolved relative to current working directory.

resolves #1333
@JacobMGEvans JacobMGEvans mentioned this issue Jun 22, 2022
Merged
JacobMGEvans added a commit that referenced this issue Jun 22, 2022
@JacobMGEvans
feat: resolve cli arg relative to current working directory (#1335)
49cf17e 
Before we were resolving the Asset directory relative to the location of  at all times.
Now the  cli arg is resolved relative to current working directory.

resolves #1333
@github-actions github-actions bot mentioned this issue Jun 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JacobMGEvans JacobMGEvans

Labels
bug Something that isn't working polish Small improvements to the experience
Projects
workers-sdk
Archived in project
Milestone
No milestone
1 participant
@JacobMGEvans