Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: resolve cli arg relative to current working directory #1335

Merged
merged 1 commit into from
Jun 22, 2022

Conversation

JacobMGEvans
Copy link
Contributor

Before we were resolving the Asset directory relative to the location of at all times.
Now the cli arg is resolved relative to current working directory.

resolves #1333

Before we were resolving the Asset directory relative to the location of  at all times.
Now the  cli arg is resolved relative to current working directory.

resolves #1333
@JacobMGEvans JacobMGEvans added enhancement New feature or request polish Small improvements to the experience labels Jun 22, 2022
@changeset-bot
Copy link

changeset-bot bot commented Jun 22, 2022

🦋 Changeset detected

Latest commit: d41aa1d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2544142860/npm-package-wrangler-1335

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/1335/npm-package-wrangler-1335

Or you can use npx with this latest build directly:

npx https://prerelease-registry.developers.workers.dev/runs/2544142860/npm-package-wrangler-1335 dev path/to/script.js

Copy link
Contributor

@threepointone threepointone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯

@JacobMGEvans JacobMGEvans merged commit 49cf17e into main Jun 22, 2022
@JacobMGEvans JacobMGEvans deleted the pathing-assets branch June 22, 2022 18:30
@github-actions github-actions bot mentioned this pull request Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request polish Small improvements to the experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FEAT: --asset should resolve relative to cwd, not wrangler.toml
2 participants