-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: wrangler init
offers to create a starter worker
#372
Conversation
🦋 Changeset detectedLatest commit: 302700b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
18f9c4a
to
5858069
Compare
5858069
to
46b2685
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay! 🎉 I left some nits, feel free to take or leave them.
46b2685
to
c206f89
Compare
Feedback applied! I don't exactly understand why the templates aren't being read in windows :( I'll have a look at it tomorrow unless someone else has any ideas. But yay if the tests actually caught a bug in windows? That means #329 is already worth it, woo @petebacondarwin. |
I can test this locally on my Windows computer tomorrow; it is set up for development. |
c206f89
to
18430af
Compare
Tests pass now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
We got feedback that `wrangler init` felt incomplete, because the immediate next thing folks need is a starter source file. So this adds another step to `wrangler init` where we offer to create that file for you. Fixes #355
18430af
to
302700b
Compare
Followup from #372 (comment), just removing some unnecessary calls to `process.cwd()`/`path.join()`, since they're already relative to where they're called from.
Followup from #372 (comment), just removing some unnecessary calls to `process.cwd()`/`path.join()`, since they're already relative to where they're called from.
…NTENT_MANIFEST` (#383) * Use `glob-to-regexp` for glob parsing and matching For Workers Sites, we'll need to match globs both outside and inside workers. Splitting glob parsing into `RegExp`s and matching allows us to serialise parsed `RegExp`s into worker bindings. `glob-to-regexp` is also the package wrangler uses for globs. * Support `file://` URLs in persistence options File-system persistence can still be enabled using a regular non-URL string root. Using a `file://` URL allows us to use query parameters for controlling path sanitisation. Workers Sites requires unsanitised storage as keys must exactly match paths (e.g. we want to lookup `myfile.test.txt` not `myfile_test_txt`). * Support `site{Include/Exclude}`, populate `__STATIC_CONTENT_MANIFEST` This brings Miniflare 3's Workers Sites implementation up to parity with Miniflare 2. Note as the Cache API is not yet supported, `{ cacheControl: { bypassCache: true } }` must be passed as options to `@cloudflare/kv-asset-handler`. Closes #372 * Populate `compatibilityDate` for internal services Recent open-source runtime binaries require this to be set * PR suggestions - Include full URL when storage protocol invalid - Always try parse storage persistence URLs - Status 405 for Method Not Allowed for Sites KV Namespace
…NTENT_MANIFEST` (#383) * Use `glob-to-regexp` for glob parsing and matching For Workers Sites, we'll need to match globs both outside and inside workers. Splitting glob parsing into `RegExp`s and matching allows us to serialise parsed `RegExp`s into worker bindings. `glob-to-regexp` is also the package wrangler uses for globs. * Support `file://` URLs in persistence options File-system persistence can still be enabled using a regular non-URL string root. Using a `file://` URL allows us to use query parameters for controlling path sanitisation. Workers Sites requires unsanitised storage as keys must exactly match paths (e.g. we want to lookup `myfile.test.txt` not `myfile_test_txt`). * Support `site{Include/Exclude}`, populate `__STATIC_CONTENT_MANIFEST` This brings Miniflare 3's Workers Sites implementation up to parity with Miniflare 2. Note as the Cache API is not yet supported, `{ cacheControl: { bypassCache: true } }` must be passed as options to `@cloudflare/kv-asset-handler`. Closes #372 * Populate `compatibilityDate` for internal services Recent open-source runtime binaries require this to be set * PR suggestions - Include full URL when storage protocol invalid - Always try parse storage persistence URLs - Status 405 for Method Not Allowed for Sites KV Namespace
…NTENT_MANIFEST` (#383) * Use `glob-to-regexp` for glob parsing and matching For Workers Sites, we'll need to match globs both outside and inside workers. Splitting glob parsing into `RegExp`s and matching allows us to serialise parsed `RegExp`s into worker bindings. `glob-to-regexp` is also the package wrangler uses for globs. * Support `file://` URLs in persistence options File-system persistence can still be enabled using a regular non-URL string root. Using a `file://` URL allows us to use query parameters for controlling path sanitisation. Workers Sites requires unsanitised storage as keys must exactly match paths (e.g. we want to lookup `myfile.test.txt` not `myfile_test_txt`). * Support `site{Include/Exclude}`, populate `__STATIC_CONTENT_MANIFEST` This brings Miniflare 3's Workers Sites implementation up to parity with Miniflare 2. Note as the Cache API is not yet supported, `{ cacheControl: { bypassCache: true } }` must be passed as options to `@cloudflare/kv-asset-handler`. Closes #372 * Populate `compatibilityDate` for internal services Recent open-source runtime binaries require this to be set * PR suggestions - Include full URL when storage protocol invalid - Always try parse storage persistence URLs - Status 405 for Method Not Allowed for Sites KV Namespace
…NTENT_MANIFEST` (#383) * Use `glob-to-regexp` for glob parsing and matching For Workers Sites, we'll need to match globs both outside and inside workers. Splitting glob parsing into `RegExp`s and matching allows us to serialise parsed `RegExp`s into worker bindings. `glob-to-regexp` is also the package wrangler uses for globs. * Support `file://` URLs in persistence options File-system persistence can still be enabled using a regular non-URL string root. Using a `file://` URL allows us to use query parameters for controlling path sanitisation. Workers Sites requires unsanitised storage as keys must exactly match paths (e.g. we want to lookup `myfile.test.txt` not `myfile_test_txt`). * Support `site{Include/Exclude}`, populate `__STATIC_CONTENT_MANIFEST` This brings Miniflare 3's Workers Sites implementation up to parity with Miniflare 2. Note as the Cache API is not yet supported, `{ cacheControl: { bypassCache: true } }` must be passed as options to `@cloudflare/kv-asset-handler`. Closes #372 * Populate `compatibilityDate` for internal services Recent open-source runtime binaries require this to be set * PR suggestions - Include full URL when storage protocol invalid - Always try parse storage persistence URLs - Status 405 for Method Not Allowed for Sites KV Namespace
We got feedback that
wrangler init
felt incomplete, because the immediate next thing folks need is a starter source file. So this adds another step towrangler init
where we offer to create that file for you.Fixes #355