fix: remove redundant process.cwd() calls in wrangler init
#383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Followup from #372 (comment), just removing some unnecessary calls to `process.cwd()`/`path.join()`, since they're already relative to where they're called from.
🦋 Changeset detectedLatest commit: 8cf4f56 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
petebacondarwin
approved these changes
Feb 3, 2022
Merged
mrbbot
added a commit
that referenced
this pull request
Oct 31, 2023
…NTENT_MANIFEST` (#383) * Use `glob-to-regexp` for glob parsing and matching For Workers Sites, we'll need to match globs both outside and inside workers. Splitting glob parsing into `RegExp`s and matching allows us to serialise parsed `RegExp`s into worker bindings. `glob-to-regexp` is also the package wrangler uses for globs. * Support `file://` URLs in persistence options File-system persistence can still be enabled using a regular non-URL string root. Using a `file://` URL allows us to use query parameters for controlling path sanitisation. Workers Sites requires unsanitised storage as keys must exactly match paths (e.g. we want to lookup `myfile.test.txt` not `myfile_test_txt`). * Support `site{Include/Exclude}`, populate `__STATIC_CONTENT_MANIFEST` This brings Miniflare 3's Workers Sites implementation up to parity with Miniflare 2. Note as the Cache API is not yet supported, `{ cacheControl: { bypassCache: true } }` must be passed as options to `@cloudflare/kv-asset-handler`. Closes #372 * Populate `compatibilityDate` for internal services Recent open-source runtime binaries require this to be set * PR suggestions - Include full URL when storage protocol invalid - Always try parse storage persistence URLs - Status 405 for Method Not Allowed for Sites KV Namespace
mrbbot
added a commit
that referenced
this pull request
Nov 1, 2023
…NTENT_MANIFEST` (#383) * Use `glob-to-regexp` for glob parsing and matching For Workers Sites, we'll need to match globs both outside and inside workers. Splitting glob parsing into `RegExp`s and matching allows us to serialise parsed `RegExp`s into worker bindings. `glob-to-regexp` is also the package wrangler uses for globs. * Support `file://` URLs in persistence options File-system persistence can still be enabled using a regular non-URL string root. Using a `file://` URL allows us to use query parameters for controlling path sanitisation. Workers Sites requires unsanitised storage as keys must exactly match paths (e.g. we want to lookup `myfile.test.txt` not `myfile_test_txt`). * Support `site{Include/Exclude}`, populate `__STATIC_CONTENT_MANIFEST` This brings Miniflare 3's Workers Sites implementation up to parity with Miniflare 2. Note as the Cache API is not yet supported, `{ cacheControl: { bypassCache: true } }` must be passed as options to `@cloudflare/kv-asset-handler`. Closes #372 * Populate `compatibilityDate` for internal services Recent open-source runtime binaries require this to be set * PR suggestions - Include full URL when storage protocol invalid - Always try parse storage persistence URLs - Status 405 for Method Not Allowed for Sites KV Namespace
mrbbot
added a commit
that referenced
this pull request
Nov 1, 2023
…NTENT_MANIFEST` (#383) * Use `glob-to-regexp` for glob parsing and matching For Workers Sites, we'll need to match globs both outside and inside workers. Splitting glob parsing into `RegExp`s and matching allows us to serialise parsed `RegExp`s into worker bindings. `glob-to-regexp` is also the package wrangler uses for globs. * Support `file://` URLs in persistence options File-system persistence can still be enabled using a regular non-URL string root. Using a `file://` URL allows us to use query parameters for controlling path sanitisation. Workers Sites requires unsanitised storage as keys must exactly match paths (e.g. we want to lookup `myfile.test.txt` not `myfile_test_txt`). * Support `site{Include/Exclude}`, populate `__STATIC_CONTENT_MANIFEST` This brings Miniflare 3's Workers Sites implementation up to parity with Miniflare 2. Note as the Cache API is not yet supported, `{ cacheControl: { bypassCache: true } }` must be passed as options to `@cloudflare/kv-asset-handler`. Closes #372 * Populate `compatibilityDate` for internal services Recent open-source runtime binaries require this to be set * PR suggestions - Include full URL when storage protocol invalid - Always try parse storage persistence URLs - Status 405 for Method Not Allowed for Sites KV Namespace
mrbbot
added a commit
that referenced
this pull request
Nov 1, 2023
…NTENT_MANIFEST` (#383) * Use `glob-to-regexp` for glob parsing and matching For Workers Sites, we'll need to match globs both outside and inside workers. Splitting glob parsing into `RegExp`s and matching allows us to serialise parsed `RegExp`s into worker bindings. `glob-to-regexp` is also the package wrangler uses for globs. * Support `file://` URLs in persistence options File-system persistence can still be enabled using a regular non-URL string root. Using a `file://` URL allows us to use query parameters for controlling path sanitisation. Workers Sites requires unsanitised storage as keys must exactly match paths (e.g. we want to lookup `myfile.test.txt` not `myfile_test_txt`). * Support `site{Include/Exclude}`, populate `__STATIC_CONTENT_MANIFEST` This brings Miniflare 3's Workers Sites implementation up to parity with Miniflare 2. Note as the Cache API is not yet supported, `{ cacheControl: { bypassCache: true } }` must be passed as options to `@cloudflare/kv-asset-handler`. Closes #372 * Populate `compatibilityDate` for internal services Recent open-source runtime binaries require this to be set * PR suggestions - Include full URL when storage protocol invalid - Always try parse storage persistence URLs - Status 405 for Method Not Allowed for Sites KV Namespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup from #372 (comment), just removing some unnecessary calls to
process.cwd()/path.join(), since they're already relative to where they're called from.