-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support setting custom HTTPS certification paths from environment variables #6479
Conversation
…nment variables As well as providing paths to custom HTTPS certificate files, it is now possible to use WRANGLER_HTTPS_KEY_PATH and WRANGLER_HTTPS_CERT_PATH environment variables. Specifying the file paths at the command line overrides specifying in environment variables. Fixes #5997
…n Wrangler tests This helper from Vitest will automatically revert to the original process.env values after each test.
🦋 Changeset detectedLatest commit: 4ef97ed The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10368361203/npm-package-wrangler-6479 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6479/npm-package-wrangler-6479 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10368361203/npm-package-wrangler-6479 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10368361203/npm-package-create-cloudflare-6479 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10368361203/npm-package-cloudflare-kv-asset-handler-6479 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10368361203/npm-package-miniflare-6479 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10368361203/npm-package-cloudflare-pages-shared-6479 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10368361203/npm-package-cloudflare-vitest-pool-workers-6479 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10368361203/npm-package-cloudflare-workers-editor-shared-6479 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10368361203/npm-package-cloudflare-workers-shared-6479 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
really nice one Pete! Thank you for working on this <3
What this PR solves / how to test
(Note that there are two auxiliary commits in this PR, which can be reviewed independently.)
Fixes #5997
Author has addressed the following