Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support setting custom HTTPS certification paths from environment variables #6479

Merged
merged 3 commits into from
Aug 14, 2024
Merged

Support setting custom HTTPS certification paths from environment variables #6479

merged 3 commits into from
Aug 14, 2024

Commits on Aug 13, 2024

  1. test: add http-options tests for providing explicit paths to files

    @petebacondarwin
    petebacondarwin committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    52cebfc View commit details
    Browse the repository at this point in the history

  2. feat: allow HTTPS custom certificate paths to be provided by a enviro… 

    …nment variables

As well as providing paths to custom HTTPS certificate files, it is now possible to use WRANGLER_HTTPS_KEY_PATH and WRANGLER_HTTPS_CERT_PATH environment variables.

Specifying the file paths at the command line overrides specifying in environment variables.

Fixes #5997
    @petebacondarwin
    petebacondarwin committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    5301b11 View commit details
    Browse the repository at this point in the history

  3. test: use vi.stubEnv() rather than manually hacking process.env i… 

    …n Wrangler tests

This helper from Vitest will automatically revert to the original process.env values after each test.
    @petebacondarwin
    petebacondarwin committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    4ef97ed View commit details
    Browse the repository at this point in the history