Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use --file option to let users set specific files to upload #174

Merged
merged 4 commits into from
Jun 7, 2023

Conversation

dana-yaish
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #174 (e45ecb5) into master (0d15445) will decrease coverage by 0.76%.
The diff coverage is 45.71%.

@@            Coverage Diff             @@
##           master     #174      +/-   ##
==========================================
- Coverage   95.40%   94.64%   -0.76%     
==========================================
  Files          68       68              
  Lines        2305     2336      +31     
==========================================
+ Hits         2199     2211      +12     
- Misses        106      125      +19     
Flag Coverage Δ
python3.10 94.64% <45.71%> (-0.76%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
codecov_cli/services/upload/__init__.py 100.00% <ø> (ø)
...odecov_cli/services/upload/coverage_file_finder.py 61.22% <44.11%> (-38.78%) ⬇️
codecov_cli/commands/upload.py 100.00% <100.00%> (ø)

Copy link
Contributor

@giovanni-guidini giovanni-guidini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general. Left a comment about using sets.
I feel that find_coverage_files is getting a bit big though... maybe it would be interesting to break it up in find_explicitly listed_files and _find_coverage_files for example. Makes it easier to read and to test.

codecov_cli/services/upload/coverage_file_finder.py Outdated Show resolved Hide resolved
codecov_cli/services/upload/coverage_file_finder.py Outdated Show resolved Hide resolved
Copy link
Contributor

@giovanni-guidini giovanni-guidini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is blocking a customer so we're deploying as is. It has been tested locally, but unit tests will follow soon.

eliatcodecov
eliatcodecov previously approved these changes Jun 6, 2023
@dana-yaish dana-yaish merged commit 18f0d55 into master Jun 7, 2023
@dana-yaish dana-yaish deleted the dana/file-fix branch June 7, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants