-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use --file option to let users set specific files to upload #174
Conversation
Codecov Report
@@ Coverage Diff @@
## master #174 +/- ##
==========================================
- Coverage 95.40% 94.64% -0.76%
==========================================
Files 68 68
Lines 2305 2336 +31
==========================================
+ Hits 2199 2211 +12
- Misses 106 125 +19
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general. Left a comment about using sets.
I feel that find_coverage_files
is getting a bit big though... maybe it would be interesting to break it up in find_explicitly listed_files
and _find_coverage_files
for example. Makes it easier to read and to test.
…d use sets for coverage files found
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is blocking a customer so we're deploying as is. It has been tested locally, but unit tests will follow soon.
No description provided.