Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark all build packages as broken; use python-build instead #1048

Closed
wants to merge 1 commit into from

Conversation

zklaus
Copy link
Contributor

@zklaus zklaus commented Aug 21, 2024

Guidelines for marking packages as broken:

  • We prefer to patch the repo data (see here)
    instead of marking packages as broken. This alternative workflow makes environments more reproducible.
  • Packages with requirements/metadata that are too strict but otherwise work are
    not technically broken and should not be marked as such.
  • Packages with missing metadata can be marked as broken on a temporary basis
    but should be patched in the repo data and be marked unbroken later.
  • In some cases where the number of users of a package is small or it is used by
    the maintainers only, we can allow packages to be marked broken more liberally.
  • We (conda-forge/core) try to make a decision on these requests within 24 hours.

What will happen when a package is marked broken?

  • Our bots will add the broken label to the package. The main label will remain on the package and this is normal.
  • Our bots will rebuild our repodata patches to remove this package from the repodata.
  • In a few hours after the anaconda.org CDN picks up the new patches, you will no longer be able to install the package from the main channel.

Checklist:

  • I want to mark a package as broken (or not broken):
    • Added a description of the problem with the package in the PR description.
    • Pinged the team for the package for their input.

There is a bit of a lingering issue with the build packages. This was discussed in the conda-forge core meeting on 2024-08-21. Here is an excerpt from the notes.
Marking the build packages as broken and directing users to the python-build packages is the agreed-upon strategy.

ping @conda-forge/build, @conda-forge/python-build, @conda-forge/core.

@zklaus zklaus marked this pull request as ready for review August 22, 2024 09:34
@zklaus zklaus requested a review from a team as a code owner August 22, 2024 09:34
@zklaus
Copy link
Contributor Author

zklaus commented Aug 22, 2024

I was too slow, #1049 took care of this.

@zklaus zklaus closed this Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant