Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build alias #15

Closed
wants to merge 7 commits into from
Closed

Add build alias #15

wants to merge 7 commits into from

Conversation

zklaus
Copy link

@zklaus zklaus commented Oct 7, 2022

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

This implements the deduplication strategy discussed in conda-forge/build-feedstock#2.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

@zklaus
Copy link
Author

zklaus commented Oct 7, 2022

@conda-forge-admin, please rerender

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2022

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you but ran into some issues. Please check the output logs of the latest rerendering GutHub actions workflow run for errors. You can also ping conda-forge/core for further assistance or try re-rendering locally.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/python-build-feedstock/actions/runs/3204302031.

- pip


- name: build
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason to name it python-build was b/c the build name was too generic and we did not wanted to take that namespace. Pinging @isuruf here who suggested this in the first place. I have to confess that I don't have a strong opinion but I'd rather renamed it to build than maintain the alias.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@zklaus
Copy link
Author

zklaus commented Oct 7, 2022

@conda-forge-admin, please rerender

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • The build section contained an unexpected subsection name. requirements is not a valid subsection name.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@zklaus zklaus marked this pull request as ready for review October 7, 2022 13:18
@CAM-Gerlach
Copy link
Member

FWIW, as a user of both build's CLI and Python API (as a Pyroma maintainer and others), member of both the PyPA and Conda packaging communities, heavy Conda user, maintainer of a handful of CF recipes and someone who's installed/updated build countless times from both PyPI and CF as well as written the developer/release documentation and CI workflows for a number of projects that all use build, I hadn't realized that there was a python-build package and build was archived until I went and manually checked the other feedstock just now.

Given how there no easy way for users to discover the other name's deprecation status, it seems highly probable that many other users will continue to make this mistake for years to come, if not forever, silently leaving them with an increasingly antiquated version of the build package. Therefore, it would seem prudent to either merge this, or actively explore another viable long-term solution.

@henryiii
Copy link
Contributor

I also went to build-feedstock from https://conda-forge.org/feedstock-outputs/, and found the "update to 0.8" PR before I realized it was archived and replaced by this one. Since the name is already available, I think using build for the conda package would have been fine. Certainly, the case where "build" shows up and works, but is stuck at an old version, is not at all ideal. I thought PyPI names were used wherever possible?

@zklaus
Copy link
Author

zklaus commented Jan 16, 2023

I also don't feel to strongly about this, but ran into the same precise issue as you guys, i.e. installed build and was caught by it being out of date. There was some discussion and apparent consensus in conda-forge/build-feedstock#2, but post-hoc some concerns surfaced.

I am not sure what is the best solution, but I agree that some solution would be desirable.

@zklaus
Copy link
Author

zklaus commented Aug 22, 2024

This issue has lingered for a long time, but in the end it was decided to stick with the name python-build only, to not add a build alias here, and to mark all previous build packages (that at this point are really very out-of-date) as broken, c.f. conda-forge/admin-requests#1048).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants