-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bot-automerge] gz-physics v7_7.1.0 #24
[bot-automerge] gz-physics v7_7.1.0 #24
Conversation
…nda-forge-pinning 2024.03.15.08.29.55
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
There seem to be a legit test failure in a test:
|
The test was added in gazebosim/gz-physics#563, so it was not there in 7.0.0. |
Not sure if this could be related, but the upstream tests were done in apt with dart 6.13.0, while here we are using dart 6.13.1 . |
I tested with both dart 6.13.0 and 6.13.1 from conda-forge, and the problem is there in both. Compilation instead fails with dart 6.12.* . |
I indeed checked the test in detail, and for some reason the top cylinder is not colliding with the bottom cylinder, just with dartsim, not sure why. |
I wonder if this is related to conda-forge/dartsim-feedstock#39 (even if then in general collisions works in conda-forge's gz-sim). |
The tests in conda-forge/dartsim-feedstock#60 suggest that there is some problem in the cylinder/cylinder contacts, indeed by changing on of the cylinders in the test to an equivalent box, the test pass fine. |
After thinking a bit about this, I do not think the two problems are related, even if both are related to cylinder/cylinder problems. In the failing tests in gz-physics, it seems that the ode collision detector is used, while in the test failing in conda-forge/dartsim-feedstock#60 the FCL collision detector is used instead. |
Actually, this is not true. All the collision detector are used, we are not sure which one is failing. |
I have a vague hint. conda-forge's ODE ships both single and double version, but dart (and almost everything else) links the single version. The Debian's ODE (in commonly used architectures) compiles the double version (see https://salsa.debian.org/games-team/ode/-/blob/81716877cafcfed6d5eab20e02580b2563a809f6/debian/rules#L10). I wonder if this could be the root cause of both this and conda-forge/dartsim-feedstock#39 . |
This is (again) not true. conda-forge's ODE ships only the double version, and dart uses it. However, conda-forge builds ode via CMake, while Debian with autotools. |
The difference between Debian and conda-forge was the use of libccd. Hopefully conda-forge/libode-feedstock#22 should fix the tests of this PR. |
conda-forge/libode-feedstock#22 fixed the detachableJoint tests, but now there is a new failure:
However, I do not know if this is also a failure for 7.0.0 . Not sure if it is related to conda-forge/dartsim-feedstock#62 . |
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day! |
It is very likely that the current package version for this feedstock is out of date.
Checklist before merging this PR:
license_file
is packagedInformation about this PR:
@conda-forge-admin,
please add bot automerge
in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun bot
in a PR comment to have theconda-forge-admin
add it for you.Pending Dependency Version Updates
Here is a list of all the pending dependency version updates for this repo. Please double check all dependencies before merging.
Dependency Analysis
Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add
bot: inspection: false
to yourconda-forge.yml
. If you encounter issues with this feature please ping the bot teamconda-forge/bot
.Analysis by source code inspection shows no discrepancy with the stated requirements in the meta.yaml.
This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/8302728024, please use this URL for debugging.