Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set ODE_WITH_LIBCCD_BOX_CYL to OFF for consistency with autotools builds used in Linux distributions #23

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Mar 19, 2024

Many major Linux distributions build ode with autotools, while in conda-forge we build it with CMake.

In ode there is a subtle difference between autotools and CMake builds, documented in conda-forge/dartsim-feedstock#62 and https://bitbucket.org/odedevs/ode/issues/87/box-cylinder-ccd-check-disabled-by-default .

To make the conda-forge package of ode behave like most users probably expect, we set the CMake options to ensure that the build behaves like the autotools build, a bit like in #22 we enable the ccd dependency.

Fix conda-forge/dartsim-feedstock#63 .

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@traversaro traversaro requested a review from repagh as a code owner March 19, 2024 09:16
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@traversaro
Copy link
Contributor Author

@conda-forge-admin, please rerender

Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/libode-feedstock/actions/runs/8340444472.

@traversaro traversaro changed the title Set ODE_WITH_LIBCCD_BOX_CYL to OFF for consistency with autotools builds Set ODE_WITH_LIBCCD_BOX_CYL to OFF for consistency with autotools builds used in Linux distributions Mar 19, 2024
@traversaro traversaro merged commit 34e4e1d into conda-forge:main Mar 19, 2024
35 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant