Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make libopencv python-independent; collapse CI jobs #365

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

h-vetinari
Copy link
Member

@h-vetinari h-vetinari commented Jun 25, 2023

Alright, this is what I promised to look in to in #363. I could see that the default python standalone build will fail, and I patched that, but it'll probably take some iteration to get right.

The commits are intended to be reviewed in sequence, the overall diff is almost unreadable.

Closes #364

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@hmaarrfk
Copy link
Contributor

curious to see what happens. Thanks!

@hmaarrfk
Copy link
Contributor

maybe skip ffmpeg 5 builds?

@h-vetinari
Copy link
Member Author

I don't understand why including some CMake modules would cause ninja not to be found, as it's clearly in the environment...

CMake Error:
  The detected version of Ninja () is less than the version of Ninja required
  by CMake (1.3).

@traversaro
Copy link
Contributor

I don't understand why including some CMake modules would cause ninja not to be found, as it's clearly in the environment...

CMake Error:
  The detected version of Ninja () is less than the version of Ninja required
  by CMake (1.3).

I am no sure this is what is causing that error, but could this be related to the fact that if OPENCV_INITIAL_PASS is enabled, there is no call to cmake_minimum_required and project, that are required by any CMake project as first step?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make libopencv independent of python version
3 participants