Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add headless options #396

Merged
merged 11 commits into from
Mar 17, 2024
Merged

Conversation

hmaarrfk
Copy link
Contributor

@hmaarrfk hmaarrfk commented Mar 11, 2024

Would benefit from: conda-forge/staged-recipes#25688

Closes #337

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@hmaarrfk
Copy link
Contributor Author

@h-vetinari i'm not sure if you have the bandwidth to attempt: #365 again

It seems that there is some use of having multiple qt builds with opencv, and at least a headless build.

@hmaarrfk
Copy link
Contributor Author

92 builds is somewhat riddiculous. we need a way to cut these down....

@hmaarrfk hmaarrfk closed this Mar 13, 2024
@hmaarrfk hmaarrfk reopened this Mar 13, 2024
@hmaarrfk hmaarrfk closed this Mar 13, 2024
@hmaarrfk hmaarrfk reopened this Mar 13, 2024
@hmaarrfk hmaarrfk changed the title Headless and protobuf dual build Add headless options Mar 13, 2024
@hmaarrfk hmaarrfk marked this pull request as ready for review March 13, 2024 16:45
@hmaarrfk
Copy link
Contributor Author

While I am not super excited about the 56 hour build time total build time (it should be closer to 6 if we could share the outputs well), it does address many grievances.

It does also give us the flexibility to remove the qt5 build readily when we feel we are ready for it.

A review would be greatly appreciated.

@h-vetinari
Copy link
Member

@h-vetinari i'm not sure if you have the bandwidth to attempt: #365 again

Hm. Perhaps I can find some time to retry. But the multi-stage build process of opencv makes that really much much harder than I've seen for basically any other library. 🥲

Copy link
Member

@h-vetinari h-vetinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very nice IMO, just a few questions/suggestions.

recipe/conda_build_config.yaml Show resolved Hide resolved
recipe/conda_build_config.yaml Outdated Show resolved Hide resolved
recipe/meta.yaml Outdated Show resolved Hide resolved
recipe/meta.yaml Outdated Show resolved Hide resolved
@hmaarrfk hmaarrfk merged commit 53d13a2 into conda-forge:main Mar 17, 2024
79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants