Rebuild icu69 #214

izahn · 2021-12-15T13:05:21Z

Checklist

Used a personal fork of the feedstock to propose changes
Bumped the build number (if the version is unchanged)
Reset the build number to 0 (if the version changed)
Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
Ensured the license file is being packaged.

Closes #207
Closes #212
Closes #213

…nda-forge-pinning 2021.11.17.15.51.01

…nda-forge-pinning 2021.12.14.08.51.52

conda-forge-linter · 2021-12-15T13:05:25Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

hmaarrfk · 2021-12-15T13:14:03Z

recipe/meta.yaml

@@ -46,6 +46,7 @@ source:
      - patches/0013-qtwebengine-missing_EVIOCGPROP.diff
      - patches/0014-qtwebengine-HAVE_SENDMMSG.diff
      - patches/google_breakpad_aarch_include.patch
+      - patches/0015-qtwebengine-fix-bison-gt-36.patch


akrherz · 2021-12-15T14:41:24Z

This is impressive and hard work you folks are putting in, but I am curious of the goals here given what has happened with the new qt-main repo. Could somebody tersely summarize what is happening ? Perhaps I am the only one curious :)

hmaarrfk · 2021-12-15T14:51:14Z

Maybe this thread can help #192

I remember somebody announcing it on a thread somewhere, but I'm not sure where.

The goal here is mostly to migrate this until something else is fixed between qt and qt-main (and qt-webengine).

Ultimately, I think the qt package will just depend on qt-main and qt-webengine but I'm not sure when that will happen.

hmaarrfk · 2021-12-15T14:54:12Z

@izahn how did you hack the aarch64 build again? The hack seems to require python 2 which is not in the mian channel for aarch64.

izahn · 2021-12-15T15:08:32Z

@izahn how did you hack the aarch64 build again? The hack seems to require python 2 which is not in the mian channel for aarch64.

Sorry which hack? I might have done something but I have an old brain and don't remember.

izahn · 2021-12-15T15:14:56Z

This is impressive and hard work you folks are putting in, but I am curious of the goals here given what has happened with the new qt-main repo. Could somebody tersely summarize what is happening ? Perhaps I am the only one curious :)

The goal is to keep qt in sync with the rest of the conda-forge ecosystem by merging the icu69 migration PR. Keeping conda-forge packages in sync with the global pinning is the mechanism by which packages are kept compatible with each other. Because the icu69 migration PR has been languishing qt is currently incompatible with the most recent tensorflow-base and everything else that has been migrated to icu 69

akrherz · 2021-12-15T15:21:55Z

The goal is to keep qt in sync with the rest of the conda-forge ecosystem

Thank you and totally agree as I have been thrashing about a lot within conda-forge due to the missing qt + icu69 combination :) This would be awesome to figure out!

hmaarrfk · 2021-12-15T15:23:48Z

@izahn was it you that cared about aarch64? maybe it was somebody else. I'm trying to use the conda-forge channel for the hack instead of main:
51b4485

Lets see if that works.

izahn · 2021-12-15T15:51:36Z

@izahn was it you that cared about aarch64? maybe it was somebody else. I'm trying to use the conda-forge channel for the hack instead of main: 51b4485

That is horrifying :-)

hmaarrfk · 2021-12-15T17:36:48Z

what makes you think we no longer need to merge build and host for qtwebengine?

izahn · 2021-12-15T18:03:42Z

what makes you think we no longer need to merge build and host for qtwebengine?

python build-locally.py completed the build without error.

hmaarrfk · 2021-12-15T18:04:16Z

oh. very cool!

hmaarrfk · 2021-12-15T18:05:02Z

Do we have time to try removing the openssl hack? I feel like openssl is already installed in the host environment....

izahn · 2021-12-15T18:15:41Z

Do we have time to try removing the openssl hack? I feel like openssl is already installed in the host environment....

My motivation for improvements here is limited because https://github.com/conda-forge/qt-main-feedstock will soon replace it if all goes well. I think we should just get the icu migration out the door and call it a day.

hmaarrfk · 2021-12-15T18:24:16Z

I guess you should at least include the fix for finding python-2 and openssl from conda-forge instead of main. Using mamba will help the solve time a bit too.

izahn · 2021-12-15T21:48:34Z

I feel optimistic that what we have here works and is good enough. I'm building linux_64_ now, any volunteers to build the others? We need

linux_aarch64_
osx_64_
win_64_

hmaarrfk · 2022-01-01T02:26:31Z

i don't think I'm against going to gcc 11.

izahn · 2022-01-02T12:44:11Z

It seems like indeed for libgcc=9.3 and icu=69 the environment is impossible to solve. Is there any objection in pinning the compilers version to 11? In this case I can solve locally (without the additional nspr/sqlite pins).

@izahn - could you please re-invite me to your fork?

@Tobias-Fischer I just sent the invite again, sorry for the delay. Happy new year!

…nda-forge-pinning 2022.01.02.17.59.50

Tobias-Fischer · 2022-01-04T21:04:41Z

Okay, I got the PR to build on aarch. At the moment the tests fail because some system requirements (libGL etc) are not installed; I asked Isuru to install them and will run the build again once that's done.

To get the PR to build, I needed to tweak some bits:

add git and patch to the build reqs as they are not installed on the aarch server
add a new patch (https://github.com/conda-forge/qt-feedstock/blob/ef79ff74f81de172ca1761eb882028b3fa251096/recipe/patches/0016-fix-gcc-11.patch) that fixes some missing includes which gcc11 complained about. In theory we could include this patch on all platforms, but to avoid rebuilding the other platforms I added a selector for linux and aarch64.

izahn · 2022-01-16T15:41:10Z

Has there been any movement here @Tobias-Fischer @hmaarrfk ? I think we just need to build and upload right?

Tobias-Fischer · 2022-01-16T18:37:46Z

Hi @isuruf - sorry to ping you. Could you please install the libGL system dependencies on the aarch server so I can build again with passing tests?

Thanks!

isuruf · 2022-01-16T18:47:30Z

Done

Tobias-Fischer · 2022-01-16T21:26:52Z

Thanks - I triggered the aarch build.

Tobias-Fischer · 2022-01-17T01:49:39Z

Aarch package: https://anaconda.org/TobiasRobotics/qt/5.12.9/download/linux-aarch64/qt-5.12.9-hb57a898_5.tar.bz2
Aarch log: https://www.dropbox.com/s/pelomc1k725go3z/build_log_aarch.txt?dl=0

pkgw · 2022-01-17T16:31:07Z

I just want to say: huge thanks to everyone working hard on these builds! The frustrating thing about this kind of work is that the better job you do, the less that the rest of the world even gets to appreciate how challenging it is ...

hmaarrfk · 2022-01-17T16:55:24Z

recipe/build.sh

@@ -63,7 +63,8 @@ rm -rf $PREFIX/bin/protoc
 # Then find the .gn or .gni files that these ninja files were created from and figure out wtf is going on.

 # qtwebengine needs python 2
-conda create -y --prefix "${SRC_DIR}/python2_hack" -c https://repo.continuum.io/pkgs/main --no-deps python=2
+# conda create -y --prefix "${SRC_DIR}/python2_hack" -c https://repo.continuum.io/pkgs/main --no-deps python=2


Its probably not worth rebuilding with this line removed, but maybe we can remember to remove it in the future.

It's already commented out, isn't it?

Tobias-Fischer · 2022-01-17T22:23:50Z

I think we have all builds now. Next step is someone from core to look at the logs and upload the packages to the conda-forge channel?

hmaarrfk · 2022-01-17T22:52:55Z

@conda-forge/core could you please upload the packages

izahn · 2022-01-18T12:36:17Z

For convenience, here are the packages and log locations collected from comments above:

izahn · 2022-02-07T15:07:27Z

@Tobias-Fischer I don't understand why but mamba can't seem to find the windows build:

CONDA_SUBDIR=win-64 mamba create -n test qt=5.12.9=h556501e_5 -q --dry-run
Encountered problems while solving:
  - nothing provides requested qt ==5.12.9 h556501e_5

And mamba wants to install the old one instead:

CONDA_SUBDIR=win-64 mamba create -n test qt -q --dry-run
  Package                 Version  Build               Channel                  Size
──────────────────────────────────────────────────────────────────────────────────────
  Install:
──────────────────────────────────────────────────────────────────────────────────────

  + ca-certificates     2021.10.8  h5b45459_0          conda-forge/win-64     176 KB
  + icu                      68.2  h0e60522_0          conda-forge/win-64      16 MB
  + jpeg                       9e  h8ffe710_0          conda-forge/win-64     373 KB
  + libclang               11.1.0  default_h5c34c98_1  conda-forge/win-64      21 MB
  + libpng                 1.6.37  h1d00b33_2          conda-forge/win-64     724 KB
  + libzlib                1.2.11  h8ffe710_1013       conda-forge/win-64      63 KB
  + openssl                1.1.1l  h8ffe710_0          conda-forge/win-64       6 MB
  + qt                     5.12.9  h5909a2a_4          conda-forge/win-64     106 MB
  + sqlite                 3.37.0  h8ffe710_0          conda-forge/win-64       1 MB
  + ucrt             10.0.20348.0  h57928b3_0          conda-forge/win-64       1 MB
  + vc                       14.2  hb210afc_6          conda-forge/win-64      13 KB
  + vs2015_runtime    14.29.30037  h902a5da_6          conda-forge/win-64       1 MB
  + zlib                   1.2.11  h8ffe710_1013       conda-forge/win-64     106 KB

Any idea what is going wrong here?

izahn · 2022-02-07T19:52:26Z

I'm especially confused because https://anaconda.org/conda-forge/qt/5.12.9/download/win-64/qt-5.12.9-h556501e_5.tar.bz2 exists, but somehow mamba doesn't see it.

jakirkham · 2022-02-07T20:02:11Z

Probably a sync issue. Working with Anaconda to resolve

isuruf · 2022-02-07T20:08:27Z

@izahn, please open issues in the future instead of commenting on PRs already merged.

conda/infrastructure#514

regro-cf-autotick-bot and others added 4 commits November 17, 2021 21:00

Rebuild for icu69

1a6790b

MNT: Re-rendered with conda-build 3.21.6, conda-smithy 3.14.3, and co…

37c32df

…nda-forge-pinning 2021.11.17.15.51.01

MNT: Re-rendered with conda-build 3.21.7, conda-smithy 3.15.1, and co…

a0a415f

…nda-forge-pinning 2021.12.14.08.51.52

stop merging build and host requirements

8246e1c

izahn requested review from ccordoba12, duncanmmacleod, gillins, mingwandroid, msarahan, ocefpaf, stuarteberg and Tobias-Fischer as code owners December 15, 2021 13:05

hmaarrfk reviewed Dec 15, 2021

View reviewed changes

improve python2 hack

c945077

Tobias-Fischer and others added 6 commits January 2, 2022 21:23

Pin gcc11, unpin nspr and sqlite, patch for gcc11

0897f2c

MNT: Re-rendered with conda-build 3.21.7, conda-smithy 3.16.1, and co…

1f65a23

…nda-forge-pinning 2022.01.02.17.59.50

Also needs patch

9f23f94

More gcc11 fixes

ab053bd

no patch for windows

e5f3920

use mamba to install py2 from cf

ef79ff7

hmaarrfk reviewed Jan 17, 2022

View reviewed changes

achimgaedke mentioned this pull request Jan 20, 2022

dependency conflict tensorflow/matplotlib most recent versions conda-forge/tensorflow-feedstock#199

Closed

isuruf merged commit 8e6de3e into conda-forge:master Jan 20, 2022

Tobias-Fischer deleted the rebuild-icu69-0-1_h1cb197 branch January 20, 2022 06:04

izahn mentioned this pull request Feb 7, 2022

revert back to qt conda-forge/qtwebkit-feedstock#21

Merged

5 tasks

izahn mentioned this pull request Feb 9, 2022

Windows package needs to be rebuilt #218

Closed

hmaarrfk mentioned this pull request Mar 29, 2022

gzclient crashes with a segfault in a non-deterministic way with qt=5.12.9=ha98a1a1_5 conda-forge/gazebo-feedstock#119

Closed

kuepe-sl mentioned this pull request Apr 12, 2022

QMediaPlayer not working #226

Open

1 task

Rebuild icu69 #214

Rebuild icu69 #214

Conversation

izahn commented Dec 15, 2021

conda-forge-linter commented Dec 15, 2021

hmaarrfk Dec 15, 2021

Choose a reason for hiding this comment

akrherz commented Dec 15, 2021

hmaarrfk commented Dec 15, 2021

hmaarrfk commented Dec 15, 2021

izahn commented Dec 15, 2021

izahn commented Dec 15, 2021

akrherz commented Dec 15, 2021

hmaarrfk commented Dec 15, 2021

izahn commented Dec 15, 2021

hmaarrfk commented Dec 15, 2021

izahn commented Dec 15, 2021

hmaarrfk commented Dec 15, 2021

hmaarrfk commented Dec 15, 2021

izahn commented Dec 15, 2021

hmaarrfk commented Dec 15, 2021

izahn commented Dec 15, 2021 • edited Loading

hmaarrfk commented Jan 1, 2022

izahn commented Jan 2, 2022

Tobias-Fischer commented Jan 4, 2022

izahn commented Jan 16, 2022

Tobias-Fischer commented Jan 16, 2022

isuruf commented Jan 16, 2022

Tobias-Fischer commented Jan 16, 2022

Tobias-Fischer commented Jan 17, 2022

pkgw commented Jan 17, 2022

hmaarrfk Jan 17, 2022

Choose a reason for hiding this comment

Tobias-Fischer Jan 17, 2022

Choose a reason for hiding this comment

Tobias-Fischer commented Jan 17, 2022

hmaarrfk commented Jan 17, 2022

izahn commented Jan 18, 2022

izahn commented Feb 7, 2022 • edited Loading

izahn commented Feb 7, 2022

jakirkham commented Feb 7, 2022

isuruf commented Feb 7, 2022

izahn commented Dec 15, 2021 •

edited

Loading

izahn commented Feb 7, 2022 •

edited

Loading