Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest ui-svelte version including DetailsPage #1238

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Jun 19, 2024

What does this PR do?

Use latest ui-svelte version including DetailsPage

@feloy feloy requested review from benoitf and a team as code owners June 19, 2024 07:37
@feloy feloy requested a review from axel7083 June 19, 2024 07:37
Signed-off-by: Philippe Martin <phmartin@redhat.com>
@axel7083
Copy link
Contributor

axel7083 commented Jun 19, 2024

I think there was a change to the Table component, that need to be addressed

$: models = models.map((m, i) => {
return {
...m,
inUse: m.id === selected,
};
});

I don't remember for sure, but I think @deboer-tim did some change to the way this information was stored ?

Moreover containers/podman-desktop#7554 makes the typing stricter for the column components.

Signed-off-by: Philippe Martin <phmartin@redhat.com>
Copy link
Contributor

@axel7083 axel7083 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@feloy feloy merged commit d3ce25b into containers:main Jun 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants