fix(typing): improve ColumnInformation renderer property typing #7554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
axel7083
requested review from
cdrage,
lstocchi and
deboer-tim
and removed request for
a team
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
deboer-tim
approved these changes
Jun 12, 2024
cdrage
pushed a commit
to cdrage/podman-desktop
that referenced
this pull request
Jun 19, 2024
…ainers#7554) * fix: typecheck Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com> * revert: unwanted modification Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com> --------- Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Improving the renderer property from
anyto more defined. This enforce that column have theobjectproperty matching the expected type.This change force use to correct the existing typing which were used for columns arrays, which were incorrect: I removed it as not needed.
Screenshot / video of UI
What issues does this PR fix or reference?
How to test this PR?