feat: showing models metadata #1345
Conversation
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
There was a problem hiding this comment.
I'm a bit puzzled about the UI and some of the values displayed. TBH i'm not able to evaluate which are the values that can be useful but when they are very long they are cut, so not very readable.
E.g.
Then i think that using the UI that we use on the k8s resources would present the values in a much more clear way
| } else { | ||
| throw new Error('cannot get model metadata'); | ||
| } | ||
| console.log('result', result); |
| throw err; | ||
| } finally { | ||
| data['duration'] = performance.now() - before; | ||
| this.telemetry.logUsage('get-metadata'); |
There was a problem hiding this comment.
| this.telemetry.logUsage('get-metadata'); | |
| this.telemetry.logUsage('get-metadata', data); |
| name: key, | ||
| value: String(value), | ||
| })); | ||
| console.log(`found ${items.length} items`); |
| const row = new TableRow<Item>({}); | ||
|
|
||
| onMount(() => { | ||
| return modelsMetadata.subscribe(metadatas => { |
There was a problem hiding this comment.
Why subscribing to a store if the only place where it is written it's here? Would it be simpler to have something like
studioClient
.getModelMetadata(modelId)
.then(result => {
items = .....
without creating/subscribing to a store which is never updated elsewhere.
There was a problem hiding this comment.
If you leave the page and come back, this is made for caching it
There was a problem hiding this comment.
ah ok, please add a comment as a reminder
I was not sure, I am open to suggestion, but we should keep in mind that those are metadatas. The most useful are probably the one related to the head count, which can be used as suggested by #1280 (comment)
@lstocchi I agree, but that would require to hardcode the keys to decide in advance where to place them, however those information are metadatas, and we are not sure for most of them where they will be. We might want to have it discuss in the UX call what do you think ? |
Sure. |
I will convert it to draft then, however this is a requirement for #1280 (which is my critical for this sprint) |
|
I do think the table is not looking consistent with the other screens. That being said, I agree with @lstocchi and would prefer we take the same approach as for the kube objects.
I think you might take the first word/token of the metadata as the category for each sections. Example |
|
Closing for now |
What does this PR do?
Adding a Tab in the model detail page for GGUF models.
If the model is already downloaded, using it, otherwise using download url to fetch metadata.
This is possible thanks to the amazing library @huggingface/gguf
Screenshot / video of UI
models-metadata.mp4
What issues does this PR fix or reference?
Fixes #1344
How to test this PR?