-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(models): adding backend logic to collect model metadata #1352
Merged
axel7083
merged 5 commits into
containers:main
from
axel7083:feature/models-metadata-backend
Jul 10, 2024
Merged
feat(models): adding backend logic to collect model metadata #1352
axel7083
merged 5 commits into
containers:main
from
axel7083:feature/models-metadata-backend
Jul 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axel7083
commented
Jul 9, 2024
axel7083
commented
Jul 9, 2024
axel7083
commented
Jul 9, 2024
axel7083
force-pushed
the
feature/models-metadata-backend
branch
from
July 9, 2024 10:16
f32bc73
to
3a7a56d
Compare
lstocchi
approved these changes
Jul 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jeffmaury
approved these changes
Jul 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't the metadata be part of the model model (😄 ) and be lazily loaded ?
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
axel7083
force-pushed
the
feature/models-metadata-backend
branch
from
July 10, 2024 11:56
f100d97
to
4150ed8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This only adds the backend logic to collect a model metadatas. See #1345 for details.
The
@huggingface/gguf
is used.Screenshot / video of UI
N/A
What issues does this PR fix or reference?
Related to #1344
Required for #1280 (comment)
How to test this PR?