Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(models): adding backend logic to collect model metadata #1352

Merged
merged 5 commits into from
Jul 10, 2024

Conversation

axel7083
Copy link
Contributor

@axel7083 axel7083 commented Jul 9, 2024

What does this PR do?

This only adds the backend logic to collect a model metadatas. See #1345 for details.

The @huggingface/gguf is used.

Screenshot / video of UI

N/A

What issues does this PR fix or reference?

Related to #1344
Required for #1280 (comment)

How to test this PR?

  • unit tests has been added

@axel7083 axel7083 requested review from benoitf, jeffmaury and a team as code owners July 9, 2024 10:13
@axel7083 axel7083 force-pushed the feature/models-metadata-backend branch from f32bc73 to 3a7a56d Compare July 9, 2024 10:16
@axel7083 axel7083 requested review from feloy and lstocchi July 9, 2024 14:06
Copy link
Contributor

@lstocchi lstocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@axel7083 axel7083 linked an issue Jul 9, 2024 that may be closed by this pull request
Copy link
Contributor

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the metadata be part of the model model (😄 ) and be lazily loaded ?

Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
@axel7083 axel7083 force-pushed the feature/models-metadata-backend branch from f100d97 to 4150ed8 Compare July 10, 2024 11:56
@axel7083 axel7083 enabled auto-merge (squash) July 10, 2024 11:58
@axel7083 axel7083 merged commit b78b9e6 into containers:main Jul 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(Models): adding inspect tab with metadata information
3 participants