Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(InferenceManager): handle podman connections #1530

Merged

Conversation

axel7083
Copy link
Contributor

What does this PR do?

Same as #1528 but for Inference Servers

Screenshot / video of UI

What issues does this PR fix or reference?

Fixes #1529
Required for #1462

How to test this PR?

  • unit tests has been provided

Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
@axel7083 axel7083 marked this pull request as ready for review August 12, 2024 16:19
@axel7083 axel7083 requested review from benoitf, jeffmaury and a team as code owners August 12, 2024 16:19
@axel7083 axel7083 requested a review from cdrage August 12, 2024 16:19
@axel7083 axel7083 requested a review from lstocchi August 13, 2024 07:47
Copy link
Contributor

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
@axel7083 axel7083 enabled auto-merge (squash) August 13, 2024 08:01
@axel7083 axel7083 merged commit d302152 into containers:main Aug 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature(InferenceManager): support specific connection given a provider
3 participants