refactor: migrate x/evidence to mocks #12749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeancarloBarrios
changed the title
JeancarloBarrios
changed the title
JeancarloBarrios
changed the title
JeancarloBarrios
changed the title
2 tasks
JeancarloBarrios
requested review from
cool-develope,
facundomedica,
kocubinski,
likhita-809 and
atheeshp
alexanderbez
approved these changes
Aug 1, 2022
JeancarloBarrios
added
A:automerge
| ) | ||
|
|
||
| func (suite *KeeperTestSuite) TestHandleDoubleSign() { | ||
| type InfractionTestSuite struct { | ||
| suite.Suite |
There was a problem hiding this comment.
I am not exactly sure, why use the mixing of mock test and integration test?
For example, why are you using simtestuitl instead of KeeperTestSuite?
There was a problem hiding this comment.
Because this seems to be more like an integration test, and logic is a bit critical to just mock, it felt more like I was testing mock expect than anything else. We discuss it a bit and for now we left it like that
There was a problem hiding this comment.
In this case, we don't use
cosmos-sdk/x/evidence/keeper/keeper_test.go
Line 145 in 035402d
There was a problem hiding this comment.
true sorry I missed that thanks!!!
cool-develope
approved these changes
Aug 1, 2022
JeancarloBarrios
added
the
A:automerge
JeancarloBarrios
removed request for
kocubinski,
facundomedica,
atheeshp and
likhita-809
Codecov Report
@@ Coverage Diff @@
## main #12749 +/- ##
==========================================
- Coverage 56.25% 56.15% -0.11%
==========================================
Files 645 641 -4
Lines 54656 54559 -97
==========================================
- Hits 30749 30638 -111
- Misses 21429 21453 +24
+ Partials 2478 2468 -10
|
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #12501
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change