-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: migrate x/evidence to mocks #12749
Merged
Merged
Changes from 19 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
44afaed
refactor: use mocks for x/evidence keeper tests
JeancarloBarrios 78626e8
generate code
JeancarloBarrios 4384f8e
testing
JeancarloBarrios 9036f93
Merge branch 'main' into JeancarloBarrios/migrate-evidence-to-mocks
JeancarloBarrios 58106f6
Merge branch 'main' into JeancarloBarrios/migrate-evidence-to-mocks
JeancarloBarrios 3dd30d9
keeper_test
JeancarloBarrios b60b791
Merge branch 'main' into JeancarloBarrios/migrate-evidence-to-mocks
JeancarloBarrios 93fff10
pre merge
JeancarloBarrios 852e721
Merge branch 'main' into JeancarloBarrios/migrate-evidence-to-mocks
JeancarloBarrios 49eaf40
kept integration test on infraction
JeancarloBarrios 70d9b49
Merge branch 'main' into JeancarloBarrios/migrate-evidence-to-mocks
JeancarloBarrios 2163400
Merge branch 'main' into JeancarloBarrios/migrate-evidence-to-mocks
JeancarloBarrios c43abed
minor interface fixes
JeancarloBarrios 497db0b
m
JeancarloBarrios 4bf778e
reset accidental modification
JeancarloBarrios bd56758
remove of unsessesary setup
JeancarloBarrios ac8ab71
Merge branch 'main' into JeancarloBarrios/migrate-evidence-to-mocks
JeancarloBarrios 035402d
Merge branch 'main' into JeancarloBarrios/migrate-evidence-to-mocks
JeancarloBarrios e2d5c64
remove unesesarry code
JeancarloBarrios 4d67983
Merge branch 'main' into JeancarloBarrios/migrate-evidence-to-mocks
JeancarloBarrios File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not exactly sure, why use the mixing of mock test and integration test?
For example, why are you using simtestuitl instead of KeeperTestSuite?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because this seems to be more like an integration test, and logic is a bit critical to just mock, it felt more like I was testing mock expect than anything else. We discuss it a bit and for now we left it like that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case, we don't use
cosmos-sdk/x/evidence/keeper/keeper_test.go
Line 145 in 035402d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
true sorry I missed that thanks!!!